Changeset 179993 in webkit for trunk/Source/JavaScriptCore/jsc.cpp

Timestamp:

Feb 12, 2015, 9:20:07 AM (10 years ago)

Author:

Brent Fulgham

Message:

[Win] [64-bit] Work around MSVC2013 Runtime Bug
​https://bugs.webkit.org/show_bug.cgi?id=141498
<rdar://problem/19803642>

Reviewed by Anders Carlsson.

Disable FMA3 instruction use in the MSVC math library to
work around a VS2013 runtime crash. We can remove this
workaround when we switch to VS2015.

Source/JavaScriptCore:

• API/tests/testapi.c: Call _set_FMA3_enable(0) to disable

FMA3 support.

• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Add new files.
• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: Ditto.
• JavaScriptCore.vcxproj/JavaScriptCoreDLL.cpp: Added.
• JavaScriptCore.vcxproj/jsc/DLLLauncherMain.cpp: Call _set_FMA3_enable(0)

to disable FMA3 support.

• jsc.cpp: Ditto.
• testRegExp.cpp: Ditto.

Source/WebKit/win:

• WebKitDLL.cpp: Call _set_FMA3_enable(0) to disable FMA3 support.

Source/WTF:

• WTF.vcxproj/WTF.vcxproj: Add new files.
• WTF.vcxproj/WTF.vcxproj.filters: Ditto.
• wtf/win/WTFDLL.cpp: Added.

Tools:

• DumpRenderTree/cg/ImageDiffCG.cpp: Call _set_FMA3_enable(0) to

disable FMA3 support.

• DumpRenderTree/win/DumpRenderTree.cpp: Ditto.
• DumpRenderTree/win/ImageDiffCairo.cpp: Ditto.
• DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
• Scripts/webkitperl/httpd.pm: Ditto.
• TestWebKitAPI/win/main.cpp: Ditto.
• WinLauncher/Common.cpp: Ditto.
• win/DLLLauncher/DLLLauncherMain.cpp: Ditto.

File:

• trunk/Source/JavaScriptCore/jsc.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/jsc.cpp

@@ -1 +1 @@
 /*
  *  Copyright (C) 1999-2000 Harri Porten ([email protected])
- *  Copyright (C) 2004, 2005, 2006, 2007, 2008, 2012, 2013 Apple Inc. All rights reserved.
+ *  Copyright (C) 2004, 2005, 2006, 2007, 2008, 2012, 2013, 2015 Apple Inc. All rights reserved.
  *  Copyright (C) 2006 Bjoern Graf ([email protected])
  *
@@ -1170 +1170 @@
 #endif
 
-#if OS(WINDOWS)
+#if OS(WINDOWS) && (defined(_M_X64) || defined(__x86_64__))
+    // The VS2013 runtime has a bug where it mis-detects AVX-capable processors
+    // if the feature has been disabled in firmware. This causes us to crash
+    // in some of the math functions. For now, we disable those optimizations
+    // because Microsoft is not going to fix the problem in VS2013.
+    // FIXME: http://webkit.org/b/141449: Remove this workaround when we switch to VS2015+.
+    _set_FMA3_enable(0);
+
     // Cygwin calls ::SetErrorMode(SEM_FAILCRITICALERRORS), which we will inherit. This is bad for
     // testing/debugging, as it causes the post-mortem debugger not to be invoked. We reset the