Changeset 180551 in webkit for trunk/Source/JavaScriptCore/bytecode/PutByIdStatus.cpp

Timestamp:

Feb 23, 2015, 11:27:24 PM (10 years ago)

Author:

[email protected]

Message:

Unreviewed, rolling out r180547 and r180550.
​https://bugs.webkit.org/show_bug.cgi?id=141957

Broke 10 Windows tests. (Requested by bfulgham_ on #webkit).

Reverted changesets:

"REGRESSION(r179429): Can't type comments in Facebook"
​https://bugs.webkit.org/show_bug.cgi?id=141859
​http://trac.webkit.org/changeset/180547

"Constructor returning null should construct an object instead
of null"
​https://bugs.webkit.org/show_bug.cgi?id=141640
​http://trac.webkit.org/changeset/180550

File:

• trunk/Source/JavaScriptCore/bytecode/PutByIdStatus.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/bytecode/PutByIdStatus.cpp

@@ -361 +361 @@
         // If the structure corresponds to something that isn't an object, then give up, since
         // we don't want to be adding properties to strings.
-        if (!structure->typeInfo().isObject())
+        if (structure->typeInfo().type() == StringType)
             return PutByIdStatus(TakesSlowPath);