Ignore:
Timestamp:
Feb 23, 2015, 11:27:24 PM (11 years ago)
Author:
[email protected]
Message:

Unreviewed, rolling out r180547 and r180550.
https://bugs.webkit.org/show_bug.cgi?id=141957

Broke 10 Windows tests. (Requested by bfulgham_ on #webkit).

Reverted changesets:

"REGRESSION(r179429): Can't type comments in Facebook"
https://bugs.webkit.org/show_bug.cgi?id=141859
http://trac.webkit.org/changeset/180547

"Constructor returning null should construct an object instead
of null"
https://bugs.webkit.org/show_bug.cgi?id=141640
http://trac.webkit.org/changeset/180550

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/JavaScriptCore/runtime/JSGlobalObject.cpp

    r180547 r180551  
    146146const ClassInfo JSGlobalObject::s_info = { "GlobalObject", &Base::s_info, &globalObjectTable, CREATE_METHOD_TABLE(JSGlobalObject) };
    147147
    148 const GlobalObjectMethodTable JSGlobalObject::s_globalObjectMethodTable = { &allowsAccessFrom, &supportsProfiling, &supportsRichSourceInfo, &shouldInterruptScript, &javaScriptRuntimeFlags, 0, &shouldInterruptScriptBeforeTimeout };
     148const GlobalObjectMethodTable JSGlobalObject::s_globalObjectMethodTable = { &allowsAccessFrom, &supportsProfiling, &supportsRichSourceInfo, &shouldInterruptScript, &javaScriptExperimentsEnabled, 0, &shouldInterruptScriptBeforeTimeout };
    149149
    150150/* Source for JSGlobalObject.lut.h
     
    174174    , m_weakRandom(Options::forceWeakRandomSeed() ? Options::forcedWeakRandomSeed() : static_cast<unsigned>(randomNumber() * (std::numeric_limits<unsigned>::max() + 1.0)))
    175175    , m_evalEnabled(true)
    176     , m_runtimeFlags()
     176    , m_experimentsEnabled(false)
    177177    , m_consoleClient(nullptr)
    178178    , m_globalObjectMethodTable(globalObjectMethodTable ? globalObjectMethodTable : &s_globalObjectMethodTable)
     
    374374
    375375    FOR_EACH_SIMPLE_BUILTIN_TYPE_WITH_CONSTRUCTOR(PUT_CONSTRUCTOR_FOR_SIMPLE_TYPE)
    376 
    377     if (m_runtimeFlags.isSymbolEnabled())
    378         putDirectWithoutTransition(vm, vm.propertyNames->Symbol, symbolConstructor, DontEnum);
    379 
     376   
    380377#undef PUT_CONSTRUCTOR_FOR_SIMPLE_TYPE
    381378    PrototypeMap& prototypeMap = vm.prototypeMap;
     
    440437    JSConsole* consoleObject = JSConsole::create(vm, m_consoleStructure.get());
    441438    putDirectWithoutTransition(vm, Identifier(exec, "console"), consoleObject, DontEnum);
    442 
     439   
    443440    resetPrototype(vm, prototype());
    444441}
Note: See TracChangeset for help on using the changeset viewer.