Changeset 1806 in webkit for trunk/JavaScriptCore/kjs/collector.cpp

Timestamp:

Aug 13, 2002, 12:39:10 AM (23 years ago)

Author:

mjs

Message:

Small speed improvement. 3% faster on cvs-js-performance, no
measurable change on cvs-static-urls.

• kjs/collector.cpp: (Collector::collect): Combine 3 loops over all objects into one, to reduce flat time and improve locality of reference.

File:

• trunk/JavaScriptCore/kjs/collector.cpp (modified) (4 diffs)

trunk/JavaScriptCore/kjs/collector.cpp

@@ -208 +208 @@
   while (block) {
     ValueImp **r = (ValueImp**)block->mem;
+      int del = 0;
     for (int i = 0; i < block->size; i++, r++) {
       ValueImp *imp = (*r);
@@ -218 +219 @@
         imp->~ValueImp();
       }
-    }
-    block = block->next;
-  }
-
-  // 2nd step: free memory
-  block = root;
-  while (block) {
-    ValueImp **r = (ValueImp**)block->mem;
-    int del = 0;
-    for (int i = 0; i < block->size; i++, r++) {
-      ValueImp *imp = (*r);
       if (imp && (imp->_flags & ValueImp::VI_DESTRUCTED) != 0) {
         free(imp);
@@ -237 +227 @@
     filled -= del;
     block->filled -= del;
-    block = block->next;
     if (del)
       deleted = true;
-  }
-
-  // delete the empty containers
-  block = root;
-  while (block) {
     CollectorBlock *next = block->next;
     if (block->filled == 0) {
@@ -260 +244 @@
     block = next;
   }
+
 #if 0
   // This is useful to track down memory leaks