Changeset 181214 in webkit for trunk/Source/JavaScriptCore/API/JSWeakObjectMapRefInternal.h

Timestamp:

Mar 7, 2015, 2:20:54 PM (10 years ago)

Author:

[email protected]

Message:

Unreviewed, rolling out r181010.
​https://bugs.webkit.org/show_bug.cgi?id=142442

Broke media/video-src-invalid-poster.html (Requested by kling
on #webkit).

Reverted changeset:

"Stale entries in WeakGCMaps are keeping tons of WeakBlocks
alive unnecessarily."
​https://bugs.webkit.org/show_bug.cgi?id=142115
​http://trac.webkit.org/changeset/181010

File:

• trunk/Source/JavaScriptCore/API/JSWeakObjectMapRefInternal.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/API/JSWeakObjectMapRefInternal.h

@@ -42 +42 @@
 struct OpaqueJSWeakObjectMap : public RefCounted<OpaqueJSWeakObjectMap> {
 public:
-    static Ref<OpaqueJSWeakObjectMap> create(JSC::VM& vm, void* data, JSWeakMapDestroyedCallback callback)
+    static PassRefPtr<OpaqueJSWeakObjectMap> create(void* data, JSWeakMapDestroyedCallback callback)
     {
-        return adoptRef(*new OpaqueJSWeakObjectMap(vm, data, callback));
+        return adoptRef(new OpaqueJSWeakObjectMap(data, callback));
     }
 
@@ -55 +55 @@
 
 private:
-    OpaqueJSWeakObjectMap(JSC::VM& vm, void* data, JSWeakMapDestroyedCallback callback)
-        : m_map(vm)
-        , m_data(data)
+    OpaqueJSWeakObjectMap(void* data, JSWeakMapDestroyedCallback callback)
+        : m_data(data)
         , m_callback(callback)
     {