Changeset 181248 in webkit for trunk/Source/JavaScriptCore/builtins/BuiltinExecutables.h

Timestamp:

Mar 8, 2015, 4:47:25 PM (10 years ago)

Author:

[email protected]

Message:

BuiltinExecutables keeps finalized Weaks around, pinning WeakBlocks.
<​https://webkit.org/b/142460>

Reviewed by Geoffrey Garen.

Make BuiltinExecutables a WeakHandleOwner so it can clear out its respective Weak members
if and when their pointees get garbage collected.

This fixes an issue I've seen locally where a WeakBlock is pinned down by a single one of
these Weak<BuiltinExecutables>.

• builtins/BuiltinExecutables.h: Make BuiltinExecutables inherit from WeakHandleOwner.

• builtins/BuiltinExecutables.cpp:

(JSC::BuiltinExecutables::finalize): Clear out the relevant member pointer when it's been
garbage collected. We use the WeakImpl's "context" field to pass the address of the member.

File:

• trunk/Source/JavaScriptCore/builtins/BuiltinExecutables.h (modified) (3 diffs)

trunk/Source/JavaScriptCore/builtins/BuiltinExecutables.h

@@ -30 +30 @@
 #include "SourceCode.h"
 #include "Weak.h"
+#include "WeakHandleOwner.h"
 
 namespace JSC {
@@ -37 +38 @@
 class VM;
 
-class BuiltinExecutables {
+class BuiltinExecutables final: private WeakHandleOwner {
     WTF_MAKE_FAST_ALLOCATED;
 public:
@@ -50 +51 @@
     
 private:
+    void finalize(Handle<Unknown>, void* context) override;
+
     VM& m_vm;
     UnlinkedFunctionExecutable* createBuiltinExecutable(const SourceCode&, const Identifier&);