Changeset 181250 in webkit for trunk/Source/JavaScriptCore/jit/JITThunks.h

Timestamp:

Mar 8, 2015, 4:58:40 PM (10 years ago)

Author:

[email protected]

Message:

JITThunks keeps finalized Weaks around, pinning WeakBlocks.
<​https://webkit.org/b/142454>

Reviewed by Darin Adler.

Make JITThunks a WeakHandleOwner so it can keep its host function map free of stale entries.
This fixes an issue I was seeing where a bunch of WeakBlocks stuck around with nothing but
finalized Weak<NativeExecutable> entries.

• jit/JITThunks.h:
• jit/JITThunks.cpp:

(JSC::JITThunks::finalize): Make JITThunks inherit from WeakHandleOwner so it can receive
a callback when the NativeExecutables get garbage collected.

(JSC::JITThunks::hostFunctionStub): Pass 'this' as the handle owner when creating Weaks.

File:

• trunk/Source/JavaScriptCore/jit/JITThunks.h (modified) (3 diffs)

trunk/Source/JavaScriptCore/jit/JITThunks.h

@@ -35 +35 @@
 #include "ThunkGenerator.h"
 #include "Weak.h"
+#include "WeakHandleOwner.h"
 #include "WeakInlines.h"
 #include <wtf/HashMap.h>
@@ -45 +46 @@
 class NativeExecutable;
 
-class JITThunks {
+class JITThunks final : private WeakHandleOwner {
 public:
     JITThunks();
-    ~JITThunks();
+    virtual ~JITThunks();
 
     MacroAssemblerCodePtr ctiNativeCall(VM*);
@@ -65 +66 @@
     typedef Mutex Lock;
     typedef MutexLocker Locker;
+
+    void finalize(Handle<Unknown>, void* context) override;
     
     typedef HashMap<ThunkGenerator, MacroAssemblerCodeRef> CTIStubMap;