Changeset 184575 in webkit for trunk/Source/JavaScriptCore/runtime/JSString.cpp

Timestamp:

May 19, 2015, 10:06:23 AM (10 years ago)

Author:

[email protected]

Message:

Give JSString a StringView getter and start using it.
<​https://webkit.org/b/145131>

Reviewed by Anders Carlsson.

When JSString is a substring internally, calling value(ExecState*) on it
will reify the baseString/start/length tuple into a new StringImpl.

For clients that only want to look at the characters of a JSString, but
don't actually need a reffable StringImpl, adding a light-weight StringView
getter lets them avoid constructing anything.

This patch adds JSString::view(ExecState*) and uses it in a few places.
There are many more opportunities to use this API, but let's do a few things
at a time.

• runtime/FunctionConstructor.cpp:

(JSC::constructFunctionSkippingEvalEnabledCheck):

• runtime/JSGlobalObjectFunctions.cpp:

(JSC::decode):
(JSC::parseInt):
(JSC::jsToNumber):
(JSC::parseFloat):
(JSC::globalFuncParseInt):
(JSC::globalFuncParseFloat):
(JSC::globalFuncEscape):
(JSC::globalFuncUnescape):

• runtime/JSGlobalObjectFunctions.h:
• runtime/JSONObject.cpp:

(JSC::JSONProtoFuncParse):

• runtime/JSString.cpp:

(JSC::JSString::getPrimitiveNumber):
(JSC::JSString::toNumber):

• runtime/JSString.h:

(JSC::JSRopeString::view):
(JSC::JSString::view):

File:

• trunk/Source/JavaScriptCore/runtime/JSString.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/runtime/JSString.cpp

@@ -386 +386 @@
 {
     result = this;
-    number = jsToNumber(value(exec));
+    number = jsToNumber(view(exec));
     return false;
 }
@@ -397 +397 @@
 double JSString::toNumber(ExecState* exec) const
 {
-    return jsToNumber(value(exec));
+    return jsToNumber(view(exec));
 }