Changeset 184617 in webkit for trunk/Source/JavaScriptCore/jsc.cpp

Timestamp:

May 19, 2015, 10:57:55 PM (10 years ago)

Author:

[email protected]

Message:

Give StringView a utf8() API.
<​https://webkit.org/b/145201>

Source/JavaScriptCore:

Reviewed by Anders Carlsson.

Use JSString::view() in a few places where we couldn't before due to StringView
lacking a utf8() API. This is a minor speed-up on Kraken's crypto subtests,
which like to call encode() with substring JSStrings.

• jsc.cpp:

(functionPrint):
(functionDebug):

• runtime/JSGlobalObjectFunctions.cpp:

(JSC::encode):

Source/WTF:

Reviewed by Anders Carlsson

Added an LChar version of StringImpl::utf8ForCharacters() and use that to give
StringView a utf8() API just like String has.

• wtf/text/StringImpl.cpp:

(WTF::StringImpl::utf8ForCharacters):

• wtf/text/StringImpl.h:
• wtf/text/StringView.cpp:

(WTF::StringView::utf8):

• wtf/text/StringView.h:

File:

• trunk/Source/JavaScriptCore/jsc.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/jsc.cpp

@@ -691 +691 @@
             putchar(' ');
 
-        printf("%s", exec->uncheckedArgument(i).toString(exec)->value(exec).utf8().data());
+        printf("%s", exec->uncheckedArgument(i).toString(exec)->view(exec).utf8().data());
     }
 
@@ -712 +712 @@
 EncodedJSValue JSC_HOST_CALL functionDebug(ExecState* exec)
 {
-    fprintf(stderr, "--> %s\n", exec->argument(0).toString(exec)->value(exec).utf8().data());
+    fprintf(stderr, "--> %s\n", exec->argument(0).toString(exec)->view(exec).utf8().data());
     return JSValue::encode(jsUndefined());
 }