Changeset 184646 in webkit for trunk/Source/JavaScriptCore/dfg/DFGLICMPhase.cpp

Timestamp:

May 20, 2015, 11:40:42 AM (10 years ago)

Author:

[email protected]

Message:

Add some assertions about the CFG in the loop pre-header creation phase
​https://bugs.webkit.org/show_bug.cgi?id=145205

Reviewed by Geoffrey Garen.

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::currentNodeOrigin): Add a FIXME.

• dfg/DFGLICMPhase.cpp:

(JSC::DFG::LICMPhase::run): Add a FIXME.

• dfg/DFGLoopPreHeaderCreationPhase.cpp:

(JSC::DFG::LoopPreHeaderCreationPhase::run): Add the assertions.

File:

• trunk/Source/JavaScriptCore/dfg/DFGLICMPhase.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/dfg/DFGLICMPhase.cpp

@@ -131 +131 @@
             DFG_ASSERT(m_graph, preHeader->terminal(), preHeader->terminal()->op() == Jump);
             
+            // We should validate the pre-header. If we placed forExit origins on nodes only if
+            // at the top of that node it is legal to exit, then we would simply check if Jump
+            // had a forExit. We should disable hoisting to pre-headers that don't validate.
+            // Or, we could only allow hoisting of things that definitely don't exit.
+            // FIXME: https://bugs.webkit.org/show_bug.cgi?id=145204
+            
             data.preHeader = preHeader;
         }