Changeset 184709 in webkit for trunk/Source/WebCore/xml/XPathExpression.cpp

Timestamp:

May 21, 2015, 12:26:55 AM (10 years ago)

Author:

Gyuyoung Kim

Message:

Purge PassRefPtr in WebCore/Modules
​https://bugs.webkit.org/show_bug.cgi?id=145112

Reviewed by Darin Adler.

As a step to remove PassRefPtr, this patch replaces PassRefPtr with Ref or RefPtr
depends on null of return value.

No new tests, no behavior changes.

• Modules/encryptedmedia/MediaKeySession.cpp:

(WebCore::MediaKeySession::create):

• Modules/encryptedmedia/MediaKeySession.h:
• Modules/encryptedmedia/MediaKeys.cpp:

(WebCore::MediaKeys::create):
(WebCore::MediaKeys::createSession):

• Modules/encryptedmedia/MediaKeys.h:
• Modules/gamepad/Gamepad.h:
• Modules/gamepad/NavigatorGamepad.cpp:

(WebCore::NavigatorGamepad::gamepadFromPlatformGamepad):

• Modules/gamepad/deprecated/Gamepad.h:
• Modules/geolocation/GeolocationError.h:

(WebCore::GeolocationError::create):

• Modules/geolocation/GeolocationPosition.h:

(WebCore::GeolocationPosition::create):

• Modules/geolocation/Geoposition.h:

(WebCore::Geoposition::create):

• Modules/geolocation/PositionError.h:

(WebCore::PositionError::create):

• Modules/geolocation/PositionOptions.h:

(WebCore::PositionOptions::create):

• Modules/mediacontrols/MediaControlsHost.cpp:

(WebCore::MediaControlsHost::create):

• Modules/mediacontrols/MediaControlsHost.h:
• Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::create):

• Modules/mediasource/MediaSource.h:
• Modules/mediastream/RTCDataChannel.cpp:

(WebCore::RTCDataChannel::create):

• Modules/mediastream/RTCDataChannel.h:
• Modules/mediastream/RTCIceCandidate.cpp:

(WebCore::RTCIceCandidate::create):

• Modules/mediastream/RTCIceCandidate.h:
• Modules/webaudio/OfflineAudioContext.cpp:

(WebCore::OfflineAudioContext::create):

• Modules/webaudio/OfflineAudioContext.h:
• Modules/webaudio/OfflineAudioDestinationNode.h:

(WebCore::OfflineAudioDestinationNode::create):

• Modules/webaudio/OscillatorNode.cpp:

(WebCore::OscillatorNode::create):

• Modules/webaudio/OscillatorNode.h:
• Modules/webdatabase/Database.cpp:

(WebCore::Database::runTransaction):

• Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::originLockFor):

• Modules/webdatabase/DatabaseTracker.h:
• Modules/webdatabase/SQLError.h:

(WebCore::SQLError::create):

• Modules/webdatabase/SQLResultSet.h:

(WebCore::SQLResultSet::create):

• Modules/webdatabase/SQLResultSetRowList.h:

(WebCore::SQLResultSetRowList::create):

• Modules/webdatabase/SQLStatementBackend.cpp:

(WebCore::SQLStatementBackend::create):

• Modules/webdatabase/SQLStatementBackend.h:
• Modules/webdatabase/SQLTransactionBackend.cpp:

(WebCore::SQLTransactionBackend::create):

• Modules/webdatabase/SQLTransactionBackend.h:
• Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::create):

• Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:
• Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::create):

• Modules/websockets/WebSocket.h:
• Modules/websockets/WebSocketChannel.h:

(WebCore::WebSocketChannel::create):

• Modules/websockets/WorkerThreadableWebSocketChannel.h:

(WebCore::WorkerThreadableWebSocketChannel::create):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::create):

• editing/InsertListCommand.h:

(WebCore::InsertListCommand::create):

• workers/Worker.cpp:

(WebCore::Worker::create):

• workers/Worker.h:
• xml/XPathExpression.cpp:

(WebCore::XPathExpression::createExpression):
(WebCore::XPathExpression::evaluate):

• xml/XPathExpression.h:

File:

• trunk/Source/WebCore/xml/XPathExpression.cpp (modified) (4 diffs)

trunk/Source/WebCore/xml/XPathExpression.cpp

@@ -46 +46 @@
 }
 
-PassRefPtr<XPathExpression> XPathExpression::createExpression(const String& expression, XPathNSResolver* resolver, ExceptionCode& ec)
+RefPtr<XPathExpression> XPathExpression::createExpression(const String& expression, XPathNSResolver* resolver, ExceptionCode& ec)
 {
     auto parsedExpression = Parser::parseStatement(expression, resolver, ec);
@@ -52 +52 @@
         return nullptr;
 
-    return adoptRef(new XPathExpression(WTF::move(parsedExpression)));
+    return adoptRef(*new XPathExpression(WTF::move(parsedExpression)));
 }
 
@@ -59 +59 @@
 }
 
-PassRefPtr<XPathResult> XPathExpression::evaluate(Node* contextNode, unsigned short type, XPathResult*, ExceptionCode& ec)
+RefPtr<XPathResult> XPathExpression::evaluate(Node* contextNode, unsigned short type, XPathResult*, ExceptionCode& ec)
 {
     if (!isValidContextNode(contextNode)) {
         ec = NOT_SUPPORTED_ERR;
-        return 0;
+        return nullptr;
     }
 
@@ -88 +88 @@
     }
 
-    return result;
+    return WTF::move(result);
 }