Changeset 184860 in webkit for trunk/Source/JavaScriptCore

Timestamp:

May 26, 2015, 10:28:32 AM (10 years ago)

Author:

[email protected]

Message:

Try to use StringView when comparing JSStrings for equality.
<​https://webkit.org/b/145379>

Reviewed by Darin Adler.

Use JSString::view() when sending two JSStrings to WTF::equal()
for comparison. This avoids creating new objects in the case where
the strings are actually substrings.

• jit/JITOperations.cpp:
• runtime/JSCJSValueInlines.h:

(JSC::JSValue::equalSlowCaseInline):
(JSC::JSValue::strictEqualSlowCaseInline):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• jit/JITOperations.cpp (modified) (1 diff)
• runtime/JSCJSValueInlines.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2015-05-26  Andreas Kling  <[email protected]>
+
+        Try to use StringView when comparing JSStrings for equality.
+        <https://webkit.org/b/145379>
+
+        Reviewed by Darin Adler.
+
+        Use JSString::view() when sending two JSStrings to WTF::equal()
+        for comparison. This avoids creating new objects in the case where
+        the strings are actually substrings.
+
+        * jit/JITOperations.cpp:
+        * runtime/JSCJSValueInlines.h:
+        (JSC::JSValue::equalSlowCaseInline):
+        (JSC::JSValue::strictEqualSlowCaseInline):
+
 2015-05-26  Yusuke Suzuki  <[email protected]>
 

trunk/Source/JavaScriptCore/jit/JITOperations.cpp

@@ -924 +924 @@
     NativeCallFrameTracer tracer(vm, exec);
 
-    bool result = WTF::equal(*asString(left)->value(exec).impl(), *asString(right)->value(exec).impl());
+    bool result = WTF::equal(asString(left)->view(exec), asString(right)->view(exec));
 #if USE(JSVALUE64)
     return JSValue::encode(jsBoolean(result));

trunk/Source/JavaScriptCore/runtime/JSCJSValueInlines.h

@@ -787 +787 @@
         bool s2 = v2.isString();
         if (s1 && s2)
-            return WTF::equal(*asString(v1)->value(exec).impl(), *asString(v2)->value(exec).impl());
+            return WTF::equal(asString(v1)->view(exec), asString(v2)->view(exec));
 
         if (v1.isUndefinedOrNull()) {
@@ -857 +857 @@
 
     if (v1.asCell()->isString() && v2.asCell()->isString())
-        return WTF::equal(*asString(v1)->value(exec).impl(), *asString(v2)->value(exec).impl());
+        return WTF::equal(asString(v1)->view(exec), asString(v2)->view(exec));
     if (v1.asCell()->isSymbol() && v2.asCell()->isSymbol())
         return asSymbol(v1)->privateName() == asSymbol(v2)->privateName();