Changeset 184860 in webkit for trunk/Source/JavaScriptCore/jit/JITOperations.cpp

Timestamp:

May 26, 2015, 10:28:32 AM (10 years ago)

Author:

[email protected]

Message:

Try to use StringView when comparing JSStrings for equality.
<​https://webkit.org/b/145379>

Reviewed by Darin Adler.

Use JSString::view() when sending two JSStrings to WTF::equal()
for comparison. This avoids creating new objects in the case where
the strings are actually substrings.

• jit/JITOperations.cpp:
• runtime/JSCJSValueInlines.h:

(JSC::JSValue::equalSlowCaseInline):
(JSC::JSValue::strictEqualSlowCaseInline):

File:

• trunk/Source/JavaScriptCore/jit/JITOperations.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/jit/JITOperations.cpp

@@ -924 +924 @@
     NativeCallFrameTracer tracer(vm, exec);
 
-    bool result = WTF::equal(*asString(left)->value(exec).impl(), *asString(right)->value(exec).impl());
+    bool result = WTF::equal(asString(left)->view(exec), asString(right)->view(exec));
 #if USE(JSVALUE64)
     return JSValue::encode(jsBoolean(result));