Changeset 184871 in webkit for trunk/Source/JavaScriptCore/builtins

Timestamp:

May 26, 2015, 2:17:22 PM (10 years ago)

Author:

Yusuke Suzuki

Message:

Reflect nits for r184863
​https://bugs.webkit.org/show_bug.cgi?id=145107

Reviewed by Darin Adler.

1. Added the copyright line.
2. Added an optional argument (/*, end */). To do so, fixed generate-js-builtins.
3. Dropped the unnecessary variable thisValue.
4. Fix the type error messages. This is also found in StringIterator.prototype.js.
5. Added tests for 0 arguments.

• builtins/Array.prototype.js:

(copyWithin):

• builtins/StringIterator.prototype.js:

(next):

• generate-js-builtins:
• tests/stress/array-copywithin.js:
• tests/stress/string-iterators.js:

Location:

trunk/Source/JavaScriptCore/builtins

Files:

• Array.prototype.js (modified) (3 diffs)
• StringIterator.prototype.js (modified) (1 diff)

trunk/Source/JavaScriptCore/builtins/Array.prototype.js

@@ -1 +1 @@
 /*
  * Copyright (C) 2014, 2015 Apple Inc. All rights reserved.
+ * Copyright (C) 2015 Yusuke Suzuki <[email protected]>.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -457 +458 @@
 }
 
-function copyWithin(target, start)
+function copyWithin(target, start /*, end */)
 {
     "use strict";
@@ -471 +472 @@
     }
 
-    var thisValue = this;
-    if (thisValue === null || thisValue === undefined)
-        throw new @TypeError("Array.copyWithin requires that |this| be not null or undefined");
-    var thisObject = @Object(thisValue);
+    if (this === null || this === undefined)
+        throw new @TypeError("Array.copyWithin requires that |this| not be null or undefined");
+    var thisObject = @Object(this);
 
     var length = @ToLength(thisObject.length);

trunk/Source/JavaScriptCore/builtins/StringIterator.prototype.js

@@ -28 +28 @@
 
     if (this == null)
-        throw new @TypeError("%StringIteratorPrototype%.next requires that |this| be not null or undefined");
+        throw new @TypeError("%StringIteratorPrototype%.next requires that |this| not be null or undefined");
 
     var position = this.@stringIteratorNextIndex;