Changeset 184917 in webkit for trunk/Source/JavaScriptCore/builtins

Timestamp:

May 27, 2015, 1:42:00 PM (10 years ago)

Author:

[email protected]

Message:

REGRESSION: These sorting idioms used by Peacekeeper and Browsermark are ~20X slower
​https://bugs.webkit.org/show_bug.cgi?id=145412

Reviewed by Darin Adler.

Use @toString instead of the String constructor because calls to the
String constructor are never optimized. (See
​https://bugs.webkit.org/show_bug.cgi?id=144458.)

This is a ~2X speedup.

• builtins/Array.prototype.js:

(sort.stringComparator):

File:

• trunk/Source/JavaScriptCore/builtins/Array.prototype.js (modified) (1 diff)

trunk/Source/JavaScriptCore/builtins/Array.prototype.js

@@ -287 +287 @@
     function stringComparator(a, b)
     {
-        var aString = @String(a);
-        var bString = @String(b);
+        var aString = @toString(a);
+        var bString = @toString(b);
 
         var aLength = aString.length;