Changeset 1850 in webkit for trunk/JavaScriptCore/kjs/internal.h

Timestamp:

Aug 16, 2002, 12:07:48 PM (23 years ago)

Author:

mjs

Message:

Final step of the Reference change. Completely separate Reference
from Value, and eliminate ReferenceImp.

18% speedup on cvs-js-performance test.

• kjs/internal.cpp, kjs/internal.h: Remove ReferenceImp.
• kjs/nodes.cpp: (Node::evaluateReference): Use Reference::makeValueReference(), not ConstReference.
• kjs/reference.cpp: (Reference::Reference): New implementation, handles both regular and value references. (Reference::makeValueReference): Incorporate functionality of ConstReference into this class. (Reference::getBase): New implementation (incorporates error vase for value references). (Reference::getPropertyName): New implementation (incorporates error case for value references). (Reference::putValue): New implementation (incorporates error case for value references). (Reference::deleteValue): New implementation (incorporates error case for value references). (Reference::getValue): New implementation (incorporates special case for value references). (Reference::isMutable): New implementation.
• kjs/reference.h: New implementation that merges ReferenceImp into the stack object.
• kjs/value.h, kjs/value.cpp: Removed all reference-related method.

File:

• trunk/JavaScriptCore/kjs/internal.h (modified) (1 diff)

trunk/JavaScriptCore/kjs/internal.h

@@ -143 +143 @@
   // ---------------------------------------------------------------------------
 
-  class ReferenceImp : public ValueImp {
-  public:
-    ReferenceImp(const Value& v, const UString& p);
-    ReferenceImp(const Value& v, unsigned p);
-    virtual void mark();
-
-    Value toPrimitive(ExecState *exec, Type preferred = UnspecifiedType) const;
-    bool toBoolean(ExecState *exec) const;
-    double toNumber(ExecState *exec) const;
-    UString toString(ExecState *exec) const;
-    Object toObject(ExecState *exec) const;
-
-    Value getBase(ExecState *) const { return Value(base); }
-    UString getPropertyName(ExecState *) const;
-    Value getValue(ExecState *exec) const;
-    void putValue(ExecState *exec, const Value& w);
-    bool deleteValue(ExecState *exec);
-
-    Type type() const { return ReferenceType; }
-
-  private:
-    ValueImp *base;
-    bool propertyNameIsNumber;
-    unsigned propertyNameAsNumber;
-    mutable UString prop;
-  };
-  
-  inline Reference::Reference(ReferenceImp *imp) : Value(imp) { }
-
   class CompletionImp : public ValueImp {
   public: