Changeset 1850 in webkit for trunk/JavaScriptCore/kjs/nodes.cpp

Timestamp:

Aug 16, 2002, 12:07:48 PM (23 years ago)

Author:

mjs

Message:

Final step of the Reference change. Completely separate Reference
from Value, and eliminate ReferenceImp.

18% speedup on cvs-js-performance test.

• kjs/internal.cpp, kjs/internal.h: Remove ReferenceImp.
• kjs/nodes.cpp: (Node::evaluateReference): Use Reference::makeValueReference(), not ConstReference.
• kjs/reference.cpp: (Reference::Reference): New implementation, handles both regular and value references. (Reference::makeValueReference): Incorporate functionality of ConstReference into this class. (Reference::getBase): New implementation (incorporates error vase for value references). (Reference::getPropertyName): New implementation (incorporates error case for value references). (Reference::putValue): New implementation (incorporates error case for value references). (Reference::deleteValue): New implementation (incorporates error case for value references). (Reference::getValue): New implementation (incorporates special case for value references). (Reference::isMutable): New implementation.
• kjs/reference.h: New implementation that merges ReferenceImp into the stack object.
• kjs/value.h, kjs/value.cpp: Removed all reference-related method.

File:

• trunk/JavaScriptCore/kjs/nodes.cpp (modified) (2 diffs)

trunk/JavaScriptCore/kjs/nodes.cpp

@@ -69 +69 @@
 #define KJS_CHECKEXCEPTIONREFERENCE \
   if (exec->hadException()) \
-    return ConstReference(UndefinedImp::staticUndefined);; \
+    return Reference::makeValueReference(Undefined());; \
   if (Collector::outOfMemory()) \
-    return ConstReference(UndefinedImp::staticUndefined); // will be picked up by KJS_CHECKEXCEPTION
+    return Reference::makeValueReference(Undefined()); // will be picked up by KJS_CHECKEXCEPTION
 
 #define KJS_CHECKEXCEPTIONLIST \
@@ -106 +106 @@
   Value v = evaluate(exec);
   KJS_CHECKEXCEPTIONREFERENCE
-  return ConstReference(v.imp());
+  return Reference::makeValueReference(v);
 }