Changeset 185122 in webkit for trunk/Source/JavaScriptCore/API/ObjcRuntimeExtras.h

Timestamp:

Jun 2, 2015, 2:24:10 PM (10 years ago)

Author:

[email protected]

Message:

JavaScriptCore: JSExport protocol with an NSInteger property converts negative values to 18446744073709552000
​https://bugs.webkit.org/show_bug.cgi?id=145563

Patch by Keith Miller <​[email protected]> on 2015-06-02
Reviewed by Darin Adler.

The Objective-C bindings were improperly converting negative
long long/NSIntegers to 18446744073709552000 because they
were converted to unsigned numbers.

• API/ObjcRuntimeExtras.h:

(parseObjCType):

• API/tests/testapi.mm:

(testObjectiveCAPIMain):
(checkNegativeNSIntegers):
(testObjectiveCAPI):

File:

• trunk/Source/JavaScriptCore/API/ObjcRuntimeExtras.h (modified) (1 diff)

trunk/Source/JavaScriptCore/API/ObjcRuntimeExtras.h

@@ -165 +165 @@
         return DelegateType::template typeInteger<long>();
     case 'q':
-        return DelegateType::template typeDouble<unsigned long long>();
+        return DelegateType::template typeDouble<long long>();
     case 'C':
         return DelegateType::template typeInteger<unsigned char>();