Changeset 187118 in webkit for trunk/Source/JavaScriptCore/dfg/DFGObjectAllocationSinkingPhase.cpp

Timestamp:

Jul 21, 2015, 1:15:54 PM (10 years ago)

Author:

[email protected]

Message:

Object allocation sinking phase is performing needless HashMap copies
​https://bugs.webkit.org/show_bug.cgi?id=147159

Reviewed by Geoffrey Garen.

The points-to analyzer in the object allocation sinking phase is
currently performing copies of its allocation and pointers tables in
several places. While this is not a huge problem since those tables are
usually small and we are in the FTL path anyway, we still shouldn't be
doing such useless copying.

This patch also removes the DFGInsertOSRHintsForUpdate files that are
no longer needed with the new object sinking phase and should have been
removed in r186795.

• CMakeLists.txt:
• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
• JavaScriptCore.xcodeproj/project.pbxproj:
• dfg/DFGInsertOSRHintsForUpdate.cpp: Removed.

(JSC::DFG::insertOSRHintsForUpdate): Deleted.

• dfg/DFGInsertOSRHintsForUpdate.h: Removed.
• dfg/DFGObjectAllocationSinkingPhase.cpp:

File:

• trunk/Source/JavaScriptCore/dfg/DFGObjectAllocationSinkingPhase.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/dfg/DFGObjectAllocationSinkingPhase.cpp

@@ -537 +537 @@
     }
 
-    const HashMap<Node*, Allocation> allocations() const
+    const HashMap<Node*, Allocation>& allocations() const
     {
         return m_allocations;
     }
 
-    const HashMap<Node*, Node*> pointers() const
+    const HashMap<Node*, Node*>& pointers() const
     {
         return m_pointers;