Changeset 18715 in webkit for trunk/JavaScriptCore/kjs/value.h

Timestamp:

Jan 9, 2007, 9:38:46 AM (18 years ago)

Author:

ap

Message:

2007-01-09 Mitz Pettel <​[email protected]>

Reviewed by Darin.

• changes for ​http://bugs.webkit.org/show_bug.cgi?id=11078 Forms Don't Submit (ASP Pages)

JavaScriptCore:

• JavaScriptCore.exp:
• kjs/value.cpp: (KJS::JSValue::toInt32): Folded toInt32Inline into this method, which was its only caller. (KJS::JSValue::toUInt32): Added a variant that reports if the conversion has succeeded.
• kjs/value.h:

WebCore:

• bindings/js/kjs_html.cpp: (KJS::JSHTMLCollectionProtoFunc::callAsFunction): Changed item() to fall back to namedItem() if its argument does not convert to a number.

LayoutTests:

• fast/dom/collection-namedItem-via-item-expected.txt: Added.
• fast/dom/collection-namedItem-via-item.html: Added.

File:

• trunk/JavaScriptCore/kjs/value.h (modified) (2 diffs)

trunk/JavaScriptCore/kjs/value.h

@@ -95 +95 @@
 
     // Integer conversions.
-    double toInteger(ExecState *exec) const;
+    double toInteger(ExecState*) const;
     int32_t toInt32(ExecState*) const;
     int32_t toInt32(ExecState*, bool& ok) const;
-    uint32_t toUInt32(ExecState *exec) const;
-    uint16_t toUInt16(ExecState *exec) const;
+    uint32_t toUInt32(ExecState*) const;
+    uint32_t toUInt32(ExecState*, bool& ok) const;
+    uint16_t toUInt16(ExecState*) const;
 
     // Garbage collection.
@@ -109 +110 @@
     JSCell *downcast();
     const JSCell *downcast() const;
-    inline int32_t toInt32Inline(ExecState*, bool& ok) const;
 
     // Give a compile time error if we try to copy one of these.