Ignore:
Timestamp:
Jan 11, 2007, 2:02:14 PM (18 years ago)
Author:
ggaren
Message:

JavaScriptCore:

Reviewed by Anders Carlsson.

Even more cleanup in preparation for fixing <rdar://problem/4608404>
WebScriptObject's _executionContext lack of ownership policy causes
crashes (e.g., in Dashcode)


Layout tests pass.


Renames:

findRootObjectForNativeHandleFunction => createRootObject
FindRootObjectForNativeHandleFunctionPtr => CreateRootObjectFunction


Also removed unnecessary use of "Bindings::" prefix.

  • JavaScriptCore.exp:
  • bindings/jni/jni_jsobject.cpp: (JavaJSObject::createNative): (JavaJSObject::convertValueToJObject): (JavaJSObject::convertJObjectToValue):
  • bindings/runtime_root.cpp: (KJS::Bindings::RootObject::setCreateRootObject):
  • bindings/runtime_root.h: (KJS::Bindings::RootObject::createRootObject):

WebCore:

Reviewed by Anders Carlsson.


Even more cleanup in preparation for fixing <rdar://problem/4608404>
WebScriptObject's _executionContext lack of ownership policy causes
crashes (e.g., in Dashcode)


Layout tests pass.


Renames:

findRootObjectForNativeHandleFunction => createRootObject
FindRootObjectForNativeHandleFunctionPtr => createRootObjectFunction
rootForView => createRootObject
getInstanceForView => getPluginInstanceForWidget

  • page/mac/FrameMac.mm: (WebCore::FrameMac::getAppletInstanceForWidget): Put the NSView * in a void* variable named "nativeHandle" to be more explicit about the fact that JavaScript's "nativeHandle" is just an NSView *.

(WebCore::getPluginInstanceForWidget): This function now does the NSView *
fetching that its callers used to do.
(WebCore::FrameMac::getEmbedInstanceForWidget): Updated for rename.
(WebCore::FrameMac::getObjectInstanceForWidget): ditto

  • page/mac/WebCoreFrameBridge.mm: Killed the WebCoreBridgeInternal category, which was really more of a shmategory. (createRootObject): Removed rootObjectForView, folding it into its only caller, the similarly named rootForView. Renamed the pair to "createRootObject" because that's what they do.

(-[WebCoreFrameBridge init]): Updated for renames

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/JavaScriptCore/JavaScriptCore.exp

    r18715 r18782  
    180180__ZN3KJS7UStringC1ERKS0_S2_
    181181__ZN3KJS7UStringaSEPKc
    182 __ZN3KJS8Bindings10RootObject40setFindRootObjectForNativeHandleFunctionEPFPS1_PvE
    183 __ZN3KJS8Bindings10RootObject41_findRootObjectForNativeHandleFunctionPtrE
     182__ZN3KJS8Bindings10RootObject17_createRootObjectE
     183__ZN3KJS8Bindings10RootObject19setCreateRootObjectEPFPS1_PvE
    184184__ZN3KJS8Bindings10RootObject7destroyEv
    185185__ZN3KJS8Bindings10throwErrorEPNS_9ExecStateENS_9ErrorTypeEP8NSString
Note: See TracChangeset for help on using the changeset viewer.