Changeset 188532 in webkit for trunk/Source/JavaScriptCore/runtime/SparseArrayValueMap.cpp

Timestamp:

Aug 17, 2015, 11:56:52 AM (10 years ago)

Author:

Yusuke Suzuki

Message:

[ES6] Implement Reflect.get
​https://bugs.webkit.org/show_bug.cgi?id=147925

Reviewed by Geoffrey Garen.

This patch implements Reflect.get API.
It can take the receiver object as the third argument.
When the receiver is specified and there's a getter for the given property name,
we call the getter with the receiver as the |this| value.

• runtime/ReflectObject.cpp:

(JSC::reflectObjectGet):

• runtime/SparseArrayValueMap.cpp:

(JSC::SparseArrayEntry::get): Deleted.

• runtime/SparseArrayValueMap.h:
• tests/stress/reflect-get.js: Added.

(shouldBe):
(shouldThrow):
(.get shouldThrow):
(.get var):
(get var.object.get hello):
(.get shouldBe):
(get var.object.set hello):

File:

• trunk/Source/JavaScriptCore/runtime/SparseArrayValueMap.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/SparseArrayValueMap.cpp

@@ -143 +143 @@
 }
 
-JSValue SparseArrayEntry::get(ExecState* exec, JSObject* array) const
-{
-    JSValue value = Base::get();
-    ASSERT(value);
-
-    if (LIKELY(!value.isGetterSetter()))
-        return value;
-
-    return callGetter(exec, array, jsCast<GetterSetter*>(value));
-}
-
 void SparseArrayEntry::put(ExecState* exec, JSValue thisValue, SparseArrayValueMap* map, JSValue value, bool shouldThrow)
 {