Changeset 189553 in webkit for trunk/Source/JavaScriptCore/dfg/DFGPlan.h

Timestamp:

Sep 9, 2015, 3:00:58 PM (10 years ago)

Author:

[email protected]

Message:

2015-09-09 Geoffrey Garen <​[email protected]>

Unreviewed, rolling back in r189516.
​https://bugs.webkit.org/show_bug.cgi?id=148989

Restored changeset:

"GC should be able to discover new strong CodeBlock references
during marking"
​https://bugs.webkit.org/show_bug.cgi?id=148981
​http://trac.webkit.org/changeset/189516

This patch caused infinite recursion on Windows because of a pre-existing
logical error in the non-parallel GC configuration. Even in non-parallel
GC, we must set the mark bit on a CodeBlock to avoid marking it twice
(or, in the case of our crash, infinitely recursively).

File:

• trunk/Source/JavaScriptCore/dfg/DFGPlan.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/dfg/DFGPlan.h

@@ -45 +45 @@
 
 class CodeBlock;
-class CodeBlockSet;
 class SlotVisitor;
 
@@ -73 +72 @@
     CompilationKey key();
     
-    void clearCodeBlockMarks(CodeBlockSet&);
-    void checkLivenessAndVisitChildren(SlotVisitor&, CodeBlockSet&);
+    void clearCodeBlockMarks();
+    void checkLivenessAndVisitChildren(SlotVisitor&);
     bool isKnownToBeLiveDuringGC();
     void cancel();