Changeset 190546 in webkit for trunk/Source/JavaScriptCore/dfg/DFGPlan.h

Timestamp:

Oct 3, 2015, 6:45:21 PM (10 years ago)

Author:

[email protected]

Message:

Unreviewed, rolling out r190522.
​https://bugs.webkit.org/show_bug.cgi?id=149787

Caused a lot of leaks (Requested by ap on #webkit).

Reverted changeset:

"Unreviewed, rolling back in r190450"
​https://bugs.webkit.org/show_bug.cgi?id=149727
​http://trac.webkit.org/changeset/190522

File:

• trunk/Source/JavaScriptCore/dfg/DFGPlan.h (modified) (3 diffs)

trunk/Source/JavaScriptCore/dfg/DFGPlan.h

@@ -56 +56 @@
 struct Plan : public ThreadSafeRefCounted<Plan> {
     Plan(
-        CodeBlock* codeBlockToCompile, CodeBlock* profiledDFGCodeBlock,
+        PassRefPtr<CodeBlock> codeBlockToCompile, CodeBlock* profiledDFGCodeBlock,
         CompilationMode, unsigned osrEntryBytecodeIndex,
         const Operands<JSValue>& mustHandleValues);
@@ -72 +72 @@
     CompilationKey key();
     
-    void rememberCodeBlocks();
+    void clearCodeBlockMarks();
     void checkLivenessAndVisitChildren(SlotVisitor&);
     bool isKnownToBeLiveDuringGC();
@@ -78 +78 @@
     
     VM& vm;
-
-    // These can be raw pointers because we visit them during every GC in checkLivenessAndVisitChildren.
-    CodeBlock* codeBlock;
-    CodeBlock* profiledDFGCodeBlock;
-
+    RefPtr<CodeBlock> codeBlock;
+    RefPtr<CodeBlock> profiledDFGCodeBlock;
     CompilationMode mode;
     const unsigned osrEntryBytecodeIndex;