Changeset 190589 in webkit for trunk/Source/JavaScriptCore/dfg/DFGCommonData.cpp

Timestamp:

Oct 5, 2015, 4:31:53 PM (10 years ago)

Author:

[email protected]

Message:

Unreviewed, rolling back in r190450
​https://bugs.webkit.org/show_bug.cgi?id=149727

The cause of the leak was VM shutdown, which happens in workers.

The fix is for CodeBlockSet to participate in lastChanceToFinalize,
since it's responsible for running CodeBlock destructors.

I ran the leaks tests locally and did not see any CodeBlock-related leaks.

Restored changesets:

"CodeBlock should be a GC object"
​https://bugs.webkit.org/show_bug.cgi?id=149727
​http://trac.webkit.org/changeset/190450

File:

• trunk/Source/JavaScriptCore/dfg/DFGCommonData.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/dfg/DFGCommonData.cpp

@@ -90 +90 @@
             }
             
-            if (ScriptExecutable* executable = inlineCallFrame->executable.get())
-                trackedReferences.check(executable);
+            if (CodeBlock* baselineCodeBlock = inlineCallFrame->baselineCodeBlock.get())
+                trackedReferences.check(baselineCodeBlock);
             
             if (inlineCallFrame->calleeRecovery.isConstant())