Changeset 190589 in webkit for trunk/Source/JavaScriptCore/dfg/DFGDesiredTransitions.h

Timestamp:

Oct 5, 2015, 4:31:53 PM (10 years ago)

Author:

[email protected]

Message:

Unreviewed, rolling back in r190450
​https://bugs.webkit.org/show_bug.cgi?id=149727

The cause of the leak was VM shutdown, which happens in workers.

The fix is for CodeBlockSet to participate in lastChanceToFinalize,
since it's responsible for running CodeBlock destructors.

I ran the leaks tests locally and did not see any CodeBlock-related leaks.

Restored changesets:

"CodeBlock should be a GC object"
​https://bugs.webkit.org/show_bug.cgi?id=149727
​http://trac.webkit.org/changeset/190450

File:

• trunk/Source/JavaScriptCore/dfg/DFGDesiredTransitions.h (modified) (3 diffs)

trunk/Source/JavaScriptCore/dfg/DFGDesiredTransitions.h

@@ -45 +45 @@
 class DesiredTransition {
 public:
-    DesiredTransition(CodeBlock*, ScriptExecutable*, Structure*, Structure*);
+    DesiredTransition(CodeBlock*, CodeBlock* codeOriginOwner, Structure*, Structure*);
 
     void reallyAdd(VM&, CommonData*);
@@ -53 +53 @@
 private:
     CodeBlock* m_codeBlock;
-    ScriptExecutable* m_codeOriginOwner;
+    CodeBlock* m_codeOriginOwner;
     Structure* m_oldStructure;
     Structure* m_newStructure;
@@ -63 +63 @@
     ~DesiredTransitions();
 
-    void addLazily(CodeBlock*, ScriptExecutable*, Structure*, Structure*);
+    void addLazily(CodeBlock*, CodeBlock* codeOriginOwner, Structure*, Structure*);
     void reallyAdd(VM&, CommonData*);
     void visitChildren(SlotVisitor&);