Changeset 190589 in webkit for trunk/Source/JavaScriptCore/jit/JITCode.h

Timestamp:

Oct 5, 2015, 4:31:53 PM (10 years ago)

Author:

[email protected]

Message:

Unreviewed, rolling back in r190450
​https://bugs.webkit.org/show_bug.cgi?id=149727

The cause of the leak was VM shutdown, which happens in workers.

The fix is for CodeBlockSet to participate in lastChanceToFinalize,
since it's responsible for running CodeBlock destructors.

I ran the leaks tests locally and did not see any CodeBlock-related leaks.

Restored changesets:

"CodeBlock should be a GC object"
​https://bugs.webkit.org/show_bug.cgi?id=149727
​http://trac.webkit.org/changeset/190450

File:

• trunk/Source/JavaScriptCore/jit/JITCode.h (modified) (1 diff)

trunk/Source/JavaScriptCore/jit/JITCode.h

@@ -122 +122 @@
     }
 
-    static std::chrono::milliseconds timeToLive(JITType jitType)
-    {
-        switch (jitType) {
-        case InterpreterThunk:
-            return std::chrono::duration_cast<std::chrono::milliseconds>(
-                std::chrono::seconds(5));
-        case BaselineJIT:
-            // Effectively 10 additional seconds, since BaselineJIT and
-            // InterpreterThunk share a CodeBlock.
-            return std::chrono::duration_cast<std::chrono::milliseconds>(
-                std::chrono::seconds(15));
-        case DFGJIT:
-            return std::chrono::duration_cast<std::chrono::milliseconds>(
-                std::chrono::seconds(20));
-        case FTLJIT:
-            return std::chrono::duration_cast<std::chrono::milliseconds>(
-                std::chrono::seconds(60));
-        default:
-            return std::chrono::milliseconds::max();
-        }
-    }
-
     static bool isLowerTier(JITType expectedLower, JITType expectedHigher)
     {