Changeset 19059 in webkit for trunk/JavaScriptCore/API/JSObjectRef.h

Timestamp:

Jan 23, 2007, 2:23:09 PM (18 years ago)

Author:

ggaren

Message:

Reviewed by Maciej Stachowiak.

Fixed <rdar://problem/4885131> Move CFString function declarations from
JSStringRef.h to JSStringRefCF.h

Also removed remaining API FIXMEs and changed them into Radars.

• API/JSClassRef.cpp: (OpaqueJSClass::OpaqueJSClass): Added Radar numbers for UTF8 conversion.

• API/JSContextRef.cpp: (JSGlobalContextCreate): Replaced FIXME for NULL JSContextRef with Radar number.

• API/JSObjectRef.h: Removed FIXME, which is unprofessional in a public header.

• API/JSStringRef.cpp: Moved CF related implementations to JSStringRefCF.cpp. (JSStringCreateWithUTF8CString): Replaced FIXME with Radar number.
• API/JSStringRef.h: Moved CF related declarations to JSStringRefCF.h. Added #include of JSStringRefCF.h as a stopgap until clients start #including it as needed by themselves.

• API/JSStringRefCF.cpp: Added. (JSStringCreateWithCFString): (JSStringCopyCFString): Replaced JSChar cast with UniChar cast, which is more appropriate for a CF call.
• API/JSStringRefCF.h: Added.
• JavaScriptCore.xcodeproj/project.pbxproj:

File:

• trunk/JavaScriptCore/API/JSObjectRef.h (modified) (2 diffs)

trunk/JavaScriptCore/API/JSObjectRef.h

@@ -286 +286 @@
 */
 typedef struct {
-    const char* const name; // FIXME: convert UTF8
+    const char* const name;
     JSObjectGetPropertyCallback getProperty;
     JSObjectSetPropertyCallback setProperty;
@@ -300 +300 @@
 */
 typedef struct {
-    const char* const name; // FIXME: convert UTF8
+    const char* const name;
     JSObjectCallAsFunctionCallback callAsFunction;
     JSPropertyAttributes attributes;