Changeset 190606 in webkit for trunk/Source/JavaScriptCore/dfg/DFGDesiredWeakReferences.cpp

Timestamp:

Oct 5, 2015, 10:51:34 PM (10 years ago)

Author:

[email protected]

Message:

Unreviewed, rolling out r190589.
​https://bugs.webkit.org/show_bug.cgi?id=149833

Caused lots of leaks, and possibly crashes (Requested by ap on
#webkit).

Reverted changeset:

"Unreviewed, rolling back in r190450"
​https://bugs.webkit.org/show_bug.cgi?id=149727
​http://trac.webkit.org/changeset/190589

File:

• trunk/Source/JavaScriptCore/dfg/DFGDesiredWeakReferences.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/dfg/DFGDesiredWeakReferences.cpp

@@ -71 +71 @@
         if (Structure* structure = jsDynamicCast<Structure*>(target)) {
             common->weakStructureReferences.append(
-                WriteBarrier<Structure>(vm, m_codeBlock, structure));
+                WriteBarrier<Structure>(vm, m_codeBlock->ownerExecutable(), structure));
         } else {
             common->weakReferences.append(
-                WriteBarrier<JSCell>(vm, m_codeBlock, target));
+                WriteBarrier<JSCell>(vm, m_codeBlock->ownerExecutable(), target));
         }
     }