Changeset 190829 in webkit for trunk/Source/JavaScriptCore/runtime/SmallStrings.cpp

Timestamp:

Oct 9, 2015, 4:17:59 PM (10 years ago)

Author:

[email protected]

Message:

No need to keep setting needsVisit flag in SmallStrings
​https://bugs.webkit.org/show_bug.cgi?id=149961

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-09
Reviewed by Andreas Kling.

SmallStrings are all initialized at once privately before the VM
enables Garbage Collection. There is no need to keep updating
this flag, as it couldn't have changed.

• runtime/SmallStrings.cpp:

(JSC::SmallStrings::createEmptyString):
(JSC::SmallStrings::createSingleCharacterString):
(JSC::SmallStrings::initialize):

• runtime/SmallStrings.h:

File:

• trunk/Source/JavaScriptCore/runtime/SmallStrings.cpp (modified) (3 diffs)

trunk/Source/JavaScriptCore/runtime/SmallStrings.cpp

@@ -110 +110 @@
     ASSERT(!m_emptyString);
     m_emptyString = JSString::createHasOtherOwner(*vm, StringImpl::empty());
-    m_needsToBeVisited = true;
+    ASSERT(m_needsToBeVisited);
 }
 
@@ -119 +119 @@
     ASSERT(!m_singleCharacterStrings[character]);
     m_singleCharacterStrings[character] = JSString::createHasOtherOwner(*vm, PassRefPtr<StringImpl>(m_storage->rep(character)));
-    m_needsToBeVisited = true;
+    ASSERT(m_needsToBeVisited);
 }
 
@@ -132 +132 @@
 {
     string = JSString::create(*vm, Identifier::fromString(vm, value).impl());
-    m_needsToBeVisited = true;
+    ASSERT(m_needsToBeVisited);
 }