Changeset 191030 in webkit for trunk/Source/JavaScriptCore/parser/ASTBuilder.h

Timestamp:

Oct 13, 2015, 8:56:53 PM (10 years ago)

Author:

Yusuke Suzuki

Message:

[ES6] Class expression should have lexical environment that has itself as an imutable binding
​https://bugs.webkit.org/show_bug.cgi?id=150089

Reviewed by Geoffrey Garen.

According to ES6 spec, class expression has its own lexical environment that holds itself
as an immutable binding[1] (section 14.5.14 step 2, 3, 4, 23)

As a result, even if the binding declared in the outer scope is overridden, methods inside
class expression can refer its class by the class name.

[1]: ​http://ecma-international.org/ecma-262/6.0/#sec-runtime-semantics-classdefinitionevaluation

• bytecompiler/NodesCodegen.cpp:

(JSC::ClassExprNode::emitBytecode):

• parser/ASTBuilder.h:

(JSC::ASTBuilder::createClassExpr):

• parser/NodeConstructors.h:

(JSC::ClassExprNode::ClassExprNode):

• parser/Nodes.h:
• parser/Parser.cpp:

(JSC::Parser<LexerType>::parseClass):

• parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createClassExpr):

• tests/es6.yaml:
• tests/stress/class-expression-generates-environment.js: Added.

(shouldBe):
(shouldThrow):
(prototype.method):
(staticMethod):
(A.prototype.method):
(A.staticMethod):
(A):

• tests/stress/class-expression-should-be-tdz-in-heritage.js: Added.

(shouldThrow):
(shouldThrow.A):

File:

• trunk/Source/JavaScriptCore/parser/ASTBuilder.h (modified) (1 diff)

trunk/Source/JavaScriptCore/parser/ASTBuilder.h

@@ -343 +343 @@
 
 #if ENABLE(ES6_CLASS_SYNTAX)
-    ClassExprNode* createClassExpr(const JSTokenLocation& location, const Identifier& name, ExpressionNode* constructor,
+    ClassExprNode* createClassExpr(const JSTokenLocation& location, const Identifier& name, VariableEnvironment& classEnvironment, ExpressionNode* constructor,
         ExpressionNode* parentClass, PropertyListNode* instanceMethods, PropertyListNode* staticMethods)
     {
-        return new (m_parserArena) ClassExprNode(location, name, constructor, parentClass, instanceMethods, staticMethods);
+        return new (m_parserArena) ClassExprNode(location, name, classEnvironment, constructor, parentClass, instanceMethods, staticMethods);
     }
 #endif