Changeset 19193 in webkit for trunk/JavaScriptCore/API/JSStringRef.cpp

Timestamp:

Jan 27, 2007, 6:58:47 PM (18 years ago)

Author:

ggaren

Message:

Reviewed by Beth Dakin.

Added some missing JSLocks, which might fix <rdar://problem/4889707>.

We need to lock whenever we might allocate memory because our FastMalloc
implementation requires clients to register their threads, which we do
through JSLock.

We also need to lock whenever modifying ref-counts because they're not
thread-safe.

• API/JSObjectRef.cpp: (JSClassCreate): Allocates memory (JSClassRetain): Modifies a ref-count (JSClassRelease): Modifies a ref-count (JSPropertyNameArrayRetain): Modifies a ref-count (JSPropertyNameArrayRelease): Modifies a ref-count
• API/JSStringRef.cpp: (JSStringRetain): Modifies a ref-count
• API/JSValueRef.cpp: (JSValueIsInstanceOfConstructor): Might allocate memory if an exception is thrown.

File:

• trunk/JavaScriptCore/API/JSStringRef.cpp (modified) (1 diff)

trunk/JavaScriptCore/API/JSStringRef.cpp

@@ -53 +53 @@
 JSStringRef JSStringRetain(JSStringRef string)
 {
+    JSLock lock;
     UString::Rep* rep = toJS(string);
     return toRef(rep->ref());