Changeset 192597 in webkit for trunk/Source/JavaScriptCore/parser/ASTBuilder.h

Timestamp:

Nov 18, 2015, 4:03:26 PM (10 years ago)

Author:

[email protected]

Message:

Unreviewed, rolling out r192436 and r192586.
​https://bugs.webkit.org/show_bug.cgi?id=151417

Caused a hang in the inspector and a crash @ google.com.
(Requested by saamyjoon on #webkit).

Reverted changesets:

"Allow any LeftHandSideExpression as a valid
AssignmentElement"
​https://bugs.webkit.org/show_bug.cgi?id=151026
​http://trac.webkit.org/changeset/192436

"There is a bug when default parameter values are mixed with
destructuring parameter values"
​https://bugs.webkit.org/show_bug.cgi?id=151369
​http://trac.webkit.org/changeset/192586

File:

• trunk/Source/JavaScriptCore/parser/ASTBuilder.h (modified) (3 diffs)

trunk/Source/JavaScriptCore/parser/ASTBuilder.h

@@ -122 +122 @@
     typedef ObjectPatternNode* ObjectPattern;
     typedef BindingNode* BindingPattern;
-    typedef AssignmentElementNode* AssignmentElement;
     static const bool CreatesAST = true;
     static const bool NeedsFreeVariableInfo = true;
@@ -526 +525 @@
     }
 
-    bool isAssignmentLocation(const Expression& pattern)
-    {
-        return pattern->isAssignmentLocation();
-    }
-
-    bool isObjectLiteral(const Expression& node)
-    {
-        return node->isObjectLiteral();
-    }
-
-    bool isArrayLiteral(const Expression& node)
-    {
-        return node->isArrayLiteral();
-    }
-
-    bool isObjectOrArrayLiteral(const Expression& node)
-    {
-        return isObjectLiteral(node) || isArrayLiteral(node);
-    }
-
     StatementNode* createEmptyStatement(const JSTokenLocation& location) { return new (m_parserArena) EmptyStatementNode(location); }
 
@@ -856 +835 @@
     {
         return new (m_parserArena) BindingNode(boundProperty, start, end, context);
-    }
-
-    AssignmentElement createAssignmentElement(const Expression& assignmentTarget, const JSTextPosition& start, const JSTextPosition& end)
-    {
-        return new (m_parserArena) AssignmentElementNode(assignmentTarget, start, end);
     }