Changeset 192597 in webkit for trunk/Source/JavaScriptCore/parser/Nodes.h

Timestamp:

Nov 18, 2015, 4:03:26 PM (10 years ago)

Author:

[email protected]

Message:

Unreviewed, rolling out r192436 and r192586.
​https://bugs.webkit.org/show_bug.cgi?id=151417

Caused a hang in the inspector and a crash @ google.com.
(Requested by saamyjoon on #webkit).

Reverted changesets:

"Allow any LeftHandSideExpression as a valid
AssignmentElement"
​https://bugs.webkit.org/show_bug.cgi?id=151026
​http://trac.webkit.org/changeset/192436

"There is a bug when default parameter values are mixed with
destructuring parameter values"
​https://bugs.webkit.org/show_bug.cgi?id=151369
​http://trac.webkit.org/changeset/192586

File:

• trunk/Source/JavaScriptCore/parser/Nodes.h (modified) (4 diffs)

trunk/Source/JavaScriptCore/parser/Nodes.h

@@ -154 +154 @@
         virtual bool isNumber() const { return false; }
         virtual bool isString() const { return false; }
-        virtual bool isObjectLiteral() const { return false; }
-        virtual bool isArrayLiteral() const { return false; }
         virtual bool isNull() const { return false; }
         virtual bool isPure(BytecodeGenerator&) const { return false; }        
@@ -595 +593 @@
         ArrayNode(const JSTokenLocation&, int elision, ElementNode*);
 
-        virtual bool isArrayLiteral() const override { return true; }
-
         ArgumentListNode* toArgumentList(ParserArena&, int, int) const;
 
@@ -652 +648 @@
         ObjectLiteralNode(const JSTokenLocation&);
         ObjectLiteralNode(const JSTokenLocation&, PropertyListNode*);
-        virtual bool isObjectLiteral() const override { return true; }
 
     private:
@@ -2054 +2049 @@
     };
 
-    class AssignmentElementNode : public DestructuringPatternNode {
-    public:
-        AssignmentElementNode(ExpressionNode* assignmentTarget, const JSTextPosition& start, const JSTextPosition& end);
-        const ExpressionNode* assignmentTarget() { return m_assignmentTarget; }
-
-        const JSTextPosition& divotStart() const { return m_divotStart; }
-        const JSTextPosition& divotEnd() const { return m_divotEnd; }
-
-    private:
-        virtual void collectBoundIdentifiers(Vector<Identifier>&) const override;
-        virtual void bindValue(BytecodeGenerator&, RegisterID*) const override;
-        virtual void toString(StringBuilder&) const override;
-
-        JSTextPosition m_divotStart;
-        JSTextPosition m_divotEnd;
-        ExpressionNode* m_assignmentTarget;
-    };
-
     class DestructuringAssignmentNode : public ExpressionNode {
     public: