Changeset 192597 in webkit for trunk/Source/JavaScriptCore/parser/SyntaxChecker.h

Timestamp:

Nov 18, 2015, 4:03:26 PM (10 years ago)

Author:

[email protected]

Message:

Unreviewed, rolling out r192436 and r192586.
​https://bugs.webkit.org/show_bug.cgi?id=151417

Caused a hang in the inspector and a crash @ google.com.
(Requested by saamyjoon on #webkit).

Reverted changesets:

"Allow any LeftHandSideExpression as a valid
AssignmentElement"
​https://bugs.webkit.org/show_bug.cgi?id=151026
​http://trac.webkit.org/changeset/192436

"There is a bug when default parameter values are mixed with
destructuring parameter values"
​https://bugs.webkit.org/show_bug.cgi?id=151369
​http://trac.webkit.org/changeset/192586

File:

• trunk/Source/JavaScriptCore/parser/SyntaxChecker.h (modified) (1 diff)

trunk/Source/JavaScriptCore/parser/SyntaxChecker.h

@@ -347 +347 @@
         return BindingDestructuring;
     }
-    DestructuringPattern createAssignmentElement(const Expression&, const JSTextPosition&, const JSTextPosition&)
-    {
-        return BindingDestructuring;
-    }
 
     bool isBindingNode(DestructuringPattern pattern)
     {
         return pattern == BindingDestructuring;
-    }
-
-    bool isAssignmentLocation(ExpressionType type)
-    {
-        return type == ResolveExpr || type == DotExpr || type == BracketExpr;
-    }
-
-    bool isObjectLiteral(ExpressionType type)
-    {
-        return type == ObjectLiteralExpr;
-    }
-
-    bool isArrayLiteral(ExpressionType type)
-    {
-        return type == ArrayLiteralExpr;
-    }
-
-    bool isObjectOrArrayLiteral(ExpressionType type)
-    {
-        return isObjectLiteral(type) || isArrayLiteral(type);
     }