Changeset 192768 in webkit for trunk/Source/JavaScriptCore/parser/Nodes.h

Timestamp:

Nov 24, 2015, 5:43:14 PM (10 years ago)

Author:

[email protected]

Message:

[JSC] support Computed Property Names in destructuring Patterns
​https://bugs.webkit.org/show_bug.cgi?id=151494

Patch by Caitlin Potter <​[email protected]> on 2015-11-24
Reviewed by Saam Barati.

Add support for computed property names in destructuring BindingPatterns
and AssignmentPatterns.

Productions BindingProperty(1) and AssignmentProperty(2) allow for any valid
PropertName(3), including ComputedPropertyName(4)

1: ​http://tc39.github.io/ecma262/#prod-BindingProperty
2: ​http://tc39.github.io/ecma262/#prod-AssignmentProperty
3: ​http://tc39.github.io/ecma262/#prod-PropertyName
4: ​http://tc39.github.io/ecma262/#prod-ComputedPropertyName

• bytecompiler/NodesCodegen.cpp:

(JSC::ObjectPatternNode::bindValue):

• parser/ASTBuilder.h:

(JSC::ASTBuilder::appendObjectPatternEntry):

• parser/Nodes.h:

(JSC::ObjectPatternNode::appendEntry):

• parser/Parser.cpp:

(JSC::Parser<LexerType>::parseDestructuringPattern):

• parser/SyntaxChecker.h:

(JSC::SyntaxChecker::operatorStackPop):

• tests/es6.yaml:
• tests/es6/destructuring_assignment_computed_properties.js: Added.

(test):
(test.computeName):
(test.loadValue):
(test.out.get a):
(test.out.set a):
(test.out.get b):
(test.out.set b):
(test.out.get c):
(test.out.set c):
(test.get var):

File:

• trunk/Source/JavaScriptCore/parser/Nodes.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/parser/Nodes.h

@@ -2018 +2018 @@
         void appendEntry(const JSTokenLocation&, const Identifier& identifier, bool wasString, DestructuringPatternNode* pattern, ExpressionNode* defaultValue)
         {
-            m_targetPatterns.append(Entry{ identifier, wasString, pattern, defaultValue });
+            m_targetPatterns.append(Entry{ identifier, nullptr, wasString, pattern, defaultValue });
+        }
+
+        void appendEntry(const JSTokenLocation&, ExpressionNode* propertyExpression, DestructuringPatternNode* pattern, ExpressionNode* defaultValue)
+        {
+            m_targetPatterns.append(Entry{ Identifier(), propertyExpression, false, pattern, defaultValue });
         }
 
@@ -2027 +2032 @@
         struct Entry {
             const Identifier& propertyName;
+            ExpressionNode* propertyExpression;
             bool wasString;
             DestructuringPatternNode* pattern;