Changeset 192935 in webkit for trunk/Source/JavaScriptCore/bytecode/ExecutableInfo.h

Timestamp:

Dec 1, 2015, 5:37:19 PM (10 years ago)

Author:

[email protected]

Message:

Unreviewed, rolling out r192914.
​https://bugs.webkit.org/show_bug.cgi?id=151734

JSC tests for this change are failing on 32 and 64-bit bots
(Requested by ryanhaddad on #webkit).

Reverted changeset:

"[ES6] Implement LLInt/Baseline Support for ES6 Generators and
enable this feature"
​https://bugs.webkit.org/show_bug.cgi?id=150792
​http://trac.webkit.org/changeset/192914

File:

• trunk/Source/JavaScriptCore/bytecode/ExecutableInfo.h (modified) (4 diffs)

trunk/Source/JavaScriptCore/bytecode/ExecutableInfo.h

@@ -27 +27 @@
 #define ExecutableInfo_h
 
-#include "GeneratorThisMode.h"
 #include "ParserModes.h"
 
 namespace JSC {
 
-// FIXME: These flags, ParserModes and propagation to XXXCodeBlocks should be reorganized.
-// https://bugs.webkit.org/show_bug.cgi?id=151547
 struct ExecutableInfo {
-    ExecutableInfo(bool needsActivation, bool usesEval, bool isStrictMode, bool isConstructor, bool isBuiltinFunction, ConstructorKind constructorKind, GeneratorThisMode generatorThisMode, SuperBinding superBinding, SourceParseMode parseMode)
+    ExecutableInfo(bool needsActivation, bool usesEval, bool isStrictMode, bool isConstructor, bool isBuiltinFunction, ConstructorKind constructorKind, bool isArrowFunction)
         : m_needsActivation(needsActivation)
         , m_usesEval(usesEval)
@@ -41 +38 @@
         , m_isConstructor(isConstructor)
         , m_isBuiltinFunction(isBuiltinFunction)
-        , m_generatorThisMode(static_cast<unsigned>(generatorThisMode))
         , m_constructorKind(static_cast<unsigned>(constructorKind))
-        , m_superBinding(static_cast<unsigned>(superBinding))
-        , m_parseMode(parseMode)
+        , m_isArrowFunction(isArrowFunction)
     {
         ASSERT(m_constructorKind == static_cast<unsigned>(constructorKind));
-        ASSERT(m_superBinding == static_cast<unsigned>(superBinding));
-        ASSERT(m_generatorThisMode == static_cast<unsigned>(generatorThisMode));
     }
 
@@ -56 +49 @@
     bool isConstructor() const { return m_isConstructor; }
     bool isBuiltinFunction() const { return m_isBuiltinFunction; }
-    GeneratorThisMode generatorThisMode() const { return static_cast<GeneratorThisMode>(m_generatorThisMode); }
     ConstructorKind constructorKind() const { return static_cast<ConstructorKind>(m_constructorKind); }
-    SuperBinding superBinding() const { return static_cast<SuperBinding>(m_superBinding); }
-    SourceParseMode parseMode() const { return m_parseMode; }
+    bool isArrowFunction() const { return m_isArrowFunction; }
 
 private:
@@ -67 +58 @@
     unsigned m_isConstructor : 1;
     unsigned m_isBuiltinFunction : 1;
-    unsigned m_generatorThisMode : 1;
     unsigned m_constructorKind : 2;
-    unsigned m_superBinding : 1;
-    SourceParseMode m_parseMode;
+    unsigned m_isArrowFunction : 1;
 };