Ignore:
Timestamp:
Dec 1, 2015, 5:37:19 PM (10 years ago)
Author:
[email protected]
Message:

Unreviewed, rolling out r192914.
​https://bugs.webkit.org/show_bug.cgi?id=151734

JSC tests for this change are failing on 32 and 64-bit bots
(Requested by ryanhaddad on #webkit).

Reverted changeset:

"[ES6] Implement LLInt/Baseline Support for ES6 Generators and
enable this feature"
​https://bugs.webkit.org/show_bug.cgi?id=150792
​http://trac.webkit.org/changeset/192914

File:
1 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.cpp

    r192914 r192935  
    5151    VM& vm, UnlinkedFunctionExecutable* executable, const SourceCode& source,
    5252    CodeSpecializationKind kind, DebuggerMode debuggerMode, ProfilerMode profilerMode,
    53     UnlinkedFunctionKind functionKind, ParserError& error, SourceParseMode parseMode)
     53    UnlinkedFunctionKind functionKind, ParserError& error, bool isArrowFunction)
    5454{
    5555    JSParserBuiltinMode builtinMode = executable->isBuiltinFunction() ? JSParserBuiltinMode::Builtin : JSParserBuiltinMode::NotBuiltin;
    … …  
    5757    ASSERT(isFunctionParseMode(executable->parseMode()));
    5858    std::unique_ptr<FunctionNode> function = parse<FunctionNode>(
    59         &vm, source, executable->name(), builtinMode, strictMode, executable->parseMode(), executable->superBinding(), error, nullptr);
     59        &vm, source, executable->name(), builtinMode, strictMode, executable->parseMode(), error, nullptr);
    6060
    6161    if (!function) {
    … …  
    6868   
    6969    UnlinkedFunctionCodeBlock* result = UnlinkedFunctionCodeBlock::create(&vm, FunctionCode,
    70         ExecutableInfo(function->needsActivation(), function->usesEval(), function->isStrictMode(), kind == CodeForConstruct, functionKind == UnlinkedBuiltinFunction, executable->constructorKind(), executable->generatorThisMode(), executable->superBinding(), parseMode));
     70        ExecutableInfo(function->needsActivation(), function->usesEval(), function->isStrictMode(), kind == CodeForConstruct, functionKind == UnlinkedBuiltinFunction, executable->constructorKind(), isArrowFunction));
    7171    auto generator(std::make_unique<BytecodeGenerator>(vm, function.get(), result, debuggerMode, profilerMode, executable->parentScopeTDZVariables()));
    7272    error = generator->generate();
    … …  
    7676}
    7777
    78 UnlinkedFunctionExecutable::UnlinkedFunctionExecutable(VM* vm, Structure* structure, const SourceCode& source, RefPtr<SourceProvider>&& sourceOverride, FunctionMetadataNode* node, UnlinkedFunctionKind kind, ConstructAbility constructAbility, GeneratorThisMode generatorThisMode, VariableEnvironment& parentScopeTDZVariables)
     78UnlinkedFunctionExecutable::UnlinkedFunctionExecutable(VM* vm, Structure* structure, const SourceCode& source, RefPtr<SourceProvider>&& sourceOverride, FunctionMetadataNode* node, UnlinkedFunctionKind kind, ConstructAbility constructAbility, VariableEnvironment& parentScopeTDZVariables)
    7979    : Base(*vm, structure)
    8080    , m_name(node->ident())
    … …  
    100100    , m_constructorKind(static_cast<unsigned>(node->constructorKind()))
    101101    , m_functionMode(node->functionMode())
    102     , m_generatorThisMode(static_cast<unsigned>(generatorThisMode))
    103     , m_superBinding(static_cast<unsigned>(node->superBinding()))
     102    , m_isArrowFunction(node->isArrowFunction())
    104103{
    105104    ASSERT(m_constructorKind == static_cast<unsigned>(node->constructorKind()));
    … …  
    182181UnlinkedFunctionCodeBlock* UnlinkedFunctionExecutable::unlinkedCodeBlockFor(
    183182    VM& vm, const SourceCode& source, CodeSpecializationKind specializationKind,
    184     DebuggerMode debuggerMode, ProfilerMode profilerMode, ParserError& error, SourceParseMode parseMode)
     183    DebuggerMode debuggerMode, ProfilerMode profilerMode, ParserError& error, bool isArrowFunction)
    185184{
    186185    switch (specializationKind) {
    … …  
    198197        vm, this, source, specializationKind, debuggerMode, profilerMode,
    199198        isBuiltinFunction() ? UnlinkedBuiltinFunction : UnlinkedNormalFunction,
    200         error, parseMode);
     199        error, isArrowFunction);
    201200   
    202201    if (error.isValid())
Note: See TracChangeset for help on using the changeset viewer.