Changeset 193427 in webkit for trunk/Source/JavaScriptCore/bindings/ScriptFunctionCall.cpp

Timestamp:

Dec 4, 2015, 10:50:10 AM (9 years ago)

Author:

Joseph Pecoraro

Message:

Web Inspector: Unskip many inspector/debugger tests
​https://bugs.webkit.org/show_bug.cgi?id=151843

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

• bindings/ScriptFunctionCall.cpp:

(Deprecated::ScriptFunctionCall::call):
Ignore TerminationExceptions, as those aren't real execution
exceptions and may be seen on Workers that have closed.

LayoutTests:

• TestExpectations:
• platform/mac/TestExpectations:

Skip specific tests.

• platform/mac-wk2/TestExpectations:

Test no longer existed.

• inspector/debugger/resources/exception.js:

(exceptionDOM):
Keep the code outputing a NotFoundException. This particular
invocation was recently changed to throw a TypeError.

File:

• trunk/Source/JavaScriptCore/bindings/ScriptFunctionCall.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/bindings/ScriptFunctionCall.cpp

@@ -141 +141 @@
 
     if (exception) {
-        hadException = true;
+        // Do not treat a terminated execution exception as having an exception. Just treat it as an empty result.
+        hadException = !isTerminatedExecutionException(exception);
         return Deprecated::ScriptValue();
     }