Changeset 194087 in webkit for trunk/Source/JavaScriptCore/runtime/JSGlobalObject.h

Timestamp:

Dec 14, 2015, 7:51:42 PM (10 years ago)

Author:

Yusuke Suzuki

Message:

Math.random should have an intrinsic thunk and it should be later handled as a DFG Node
​https://bugs.webkit.org/show_bug.cgi?id=152133

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

In this patch, we implement new RandomIntrinsic. It emits a machine code to generate random numbers efficiently.
And later it will be recognized by DFG and converted to ArithRandom node.
It provides type information SpecDoubleReal since Math.random only generates a number within [0, 1.0).

Currently, only 64bit version is supported. On 32bit environment, ArithRandom will be converted to callOperation.
While it emits a function call, ArithRandom node on 32bit still represents SpecDoubleReal as a result type.

• dfg/DFGAbstractHeap.h:
• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsicCall):

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGNodeType.h:
• dfg/DFGOperations.cpp:
• dfg/DFGOperations.h:
• dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

• dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

• dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::compileArithRandom):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::compileArithRandom):

• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::DFG::LowerDFGToLLVM::compileNode):
(JSC::FTL::DFG::LowerDFGToLLVM::compileArithRandom):

• jit/AssemblyHelpers.cpp:

(JSC::emitRandomThunkImpl):
(JSC::AssemblyHelpers::emitRandomThunk):

• jit/AssemblyHelpers.h:
• jit/JITOperations.h:
• jit/ThunkGenerators.cpp:

(JSC::randomThunkGenerator):

• jit/ThunkGenerators.h:
• runtime/Intrinsic.h:
• runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::weakRandomOffset):

• runtime/MathObject.cpp:

(JSC::MathObject::finishCreation):

• runtime/VM.cpp:

(JSC::thunkGeneratorForIntrinsic):

• tests/stress/random-53bit.js: Added.

(test):

• tests/stress/random-in-range.js: Added.

(test):

Source/WTF:

Change 64bit random to double logic to convert efficiently.

• wtf/WeakRandom.h:

(WTF::WeakRandom::get):
(WTF::WeakRandom::lowOffset):
(WTF::WeakRandom::highOffset):

LayoutTests:

Add new regression test.

• js/regress/math-random-expected.txt: Added.
• js/regress/math-random.html: Added.
• js/regress/script-tests/math-random.js: Added.

(test):

File:

• trunk/Source/JavaScriptCore/runtime/JSGlobalObject.h (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/JSGlobalObject.h

@@ -666 +666 @@
     TemplateRegistry& templateRegistry() { return m_templateRegistry; }
 
+    static ptrdiff_t weakRandomOffset() { return OBJECT_OFFSETOF(JSGlobalObject, m_weakRandom); }
     double weakRandomNumber() { return m_weakRandom.get(); }
     unsigned weakRandomInteger() { return m_weakRandom.getUint32(); }