Changeset 195000 in webkit for trunk/Source/JavaScriptCore/runtime/Executable.h

Timestamp:

Jan 13, 2016, 4:28:40 PM (9 years ago)

Author:

[email protected]

Message:

NativeExecutable should have a name field
​https://bugs.webkit.org/show_bug.cgi?id=153083

Reviewed by Geoffrey Garen.

This is going to help the SamplingProfiler come up
with names for NativeExecutable objects it encounters.

• jit/JITThunks.cpp:

(JSC::JITThunks::finalize):
(JSC::JITThunks::hostFunctionStub):

• jit/JITThunks.h:
• runtime/Executable.h:
• runtime/JSBoundFunction.cpp:

(JSC::JSBoundFunction::create):

• runtime/JSFunction.cpp:

(JSC::JSFunction::create):
(JSC::JSFunction::lookUpOrCreateNativeExecutable):

• runtime/JSFunction.h:

(JSC::JSFunction::createImpl):

• runtime/JSNativeStdFunction.cpp:

(JSC::JSNativeStdFunction::create):

• runtime/VM.cpp:

(JSC::thunkGeneratorForIntrinsic):
(JSC::VM::getHostFunction):

• runtime/VM.h:

(JSC::VM::getCTIStub):
(JSC::VM::exceptionOffset):

File:

• trunk/Source/JavaScriptCore/runtime/Executable.h (modified) (4 diffs)

trunk/Source/JavaScriptCore/runtime/Executable.h

@@ -258 +258 @@
     static const unsigned StructureFlags = Base::StructureFlags | StructureIsImmortal;
 
-    static NativeExecutable* create(VM& vm, PassRefPtr<JITCode> callThunk, NativeFunction function, PassRefPtr<JITCode> constructThunk, NativeFunction constructor, Intrinsic intrinsic)
+    static NativeExecutable* create(VM& vm, PassRefPtr<JITCode> callThunk, NativeFunction function, PassRefPtr<JITCode> constructThunk, NativeFunction constructor, Intrinsic intrinsic, const String& name)
     {
         NativeExecutable* executable;
         executable = new (NotNull, allocateCell<NativeExecutable>(vm.heap)) NativeExecutable(vm, function, constructor);
-        executable->finishCreation(vm, callThunk, constructThunk, intrinsic);
+        executable->finishCreation(vm, callThunk, constructThunk, intrinsic, name);
         return executable;
     }
@@ -295 +295 @@
     Intrinsic intrinsic() const;
 
+    const String& name() const { return m_name; }
+
 protected:
-    void finishCreation(VM& vm, PassRefPtr<JITCode> callThunk, PassRefPtr<JITCode> constructThunk, Intrinsic intrinsic)
+    void finishCreation(VM& vm, PassRefPtr<JITCode> callThunk, PassRefPtr<JITCode> constructThunk, Intrinsic intrinsic, const String& name)
     {
         Base::finishCreation(vm);
@@ -302 +304 @@
         m_jitCodeForConstruct = constructThunk;
         m_intrinsic = intrinsic;
+        m_name = name;
     }
 
@@ -318 +321 @@
         
     Intrinsic m_intrinsic;
+
+    String m_name;
 };