Changeset 197308 in webkit for trunk/Source/JavaScriptCore/builtins/BuiltinExecutables.cpp

Timestamp:

Feb 28, 2016, 9:26:05 PM (9 years ago)

Author:

[email protected]

Message:

Make JSFunction.name allocation fully lazy.
<​https://webkit.org/b/154806>

Reviewed by Saam Barati.

We were reifying the "name" field on functions lazily, but created the string
value itself up front. This patch gets rid of the up-front allocation,
saving us a JSString allocation per function in most cases.

• builtins/BuiltinExecutables.cpp:

(JSC::createExecutableInternal):

• bytecode/UnlinkedFunctionExecutable.cpp:

(JSC::UnlinkedFunctionExecutable::visitChildren):

• bytecode/UnlinkedFunctionExecutable.h:
• runtime/CodeCache.cpp:

(JSC::CodeCache::getFunctionExecutableFromGlobalCode):

• runtime/Executable.h:
• runtime/JSFunction.cpp:

(JSC::JSFunction::reifyName):

File:

• trunk/Source/JavaScriptCore/builtins/BuiltinExecutables.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/builtins/BuiltinExecutables.cpp

@@ -110 +110 @@
     VariableEnvironment dummyTDZVariables;
     UnlinkedFunctionExecutable* functionExecutable = UnlinkedFunctionExecutable::create(&vm, source, metadata, kind, constructAbility, dummyTDZVariables, DerivedContextType::None, WTFMove(sourceOverride));
-    functionExecutable->setNameValue(vm, jsString(&vm, name.string()));
     return functionExecutable;
 }