Changeset 197308 in webkit for trunk/Source/JavaScriptCore/runtime/Executable.h

Timestamp:

Feb 28, 2016, 9:26:05 PM (9 years ago)

Author:

[email protected]

Message:

Make JSFunction.name allocation fully lazy.
<​https://webkit.org/b/154806>

Reviewed by Saam Barati.

We were reifying the "name" field on functions lazily, but created the string
value itself up front. This patch gets rid of the up-front allocation,
saving us a JSString allocation per function in most cases.

• builtins/BuiltinExecutables.cpp:

(JSC::createExecutableInternal):

• bytecode/UnlinkedFunctionExecutable.cpp:

(JSC::UnlinkedFunctionExecutable::visitChildren):

• bytecode/UnlinkedFunctionExecutable.h:
• runtime/CodeCache.cpp:

(JSC::CodeCache::getFunctionExecutableFromGlobalCode):

• runtime/Executable.h:
• runtime/JSFunction.cpp:

(JSC::JSFunction::reifyName):

File:

• trunk/Source/JavaScriptCore/runtime/Executable.h (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/Executable.h

@@ -668 +668 @@
     const Identifier& name() { return m_unlinkedExecutable->name(); }
     const Identifier& inferredName() { return m_unlinkedExecutable->inferredName(); }
-    JSString* nameValue() const { return m_unlinkedExecutable->nameValue(); }
     size_t parameterCount() const { return m_unlinkedExecutable->parameterCount(); } // Excluding 'this'!
     SourceParseMode parseMode() const { return m_unlinkedExecutable->parseMode(); }