Changeset 197391 in webkit for trunk/Source/JavaScriptCore/runtime/JSModuleNamespaceObject.cpp

Timestamp:

Mar 1, 2016, 12:11:20 AM (9 years ago)

Author:

[email protected]

Message:

PreventExtensions should be a virtual method in the method table.
​https://bugs.webkit.org/show_bug.cgi?id=154800

Reviewed by Yusuke Suzuki.

This patch makes us more consistent with how the ES6 specification models the
PreventExtensions trap. Moving this method into ClassInfo::methodTable
is a prerequisite for implementing Proxy.PreventExtensions.

• runtime/ClassInfo.h:
• runtime/JSCell.cpp:

(JSC::JSCell::getGenericPropertyNames):
(JSC::JSCell::preventExtensions):

• runtime/JSCell.h:
• runtime/JSModuleNamespaceObject.cpp:

(JSC::JSModuleNamespaceObject::JSModuleNamespaceObject):
(JSC::JSModuleNamespaceObject::finishCreation):
(JSC::JSModuleNamespaceObject::destroy):

• runtime/JSModuleNamespaceObject.h:

(JSC::JSModuleNamespaceObject::create):
(JSC::JSModuleNamespaceObject::moduleRecord):

• runtime/JSObject.cpp:

(JSC::JSObject::freeze):
(JSC::JSObject::preventExtensions):
(JSC::JSObject::reifyAllStaticProperties):

• runtime/JSObject.h:

(JSC::JSObject::isSealed):
(JSC::JSObject::isFrozen):
(JSC::JSObject::isExtensible):

• runtime/ObjectConstructor.cpp:

(JSC::objectConstructorSeal):
(JSC::objectConstructorFreeze):
(JSC::objectConstructorPreventExtensions):
(JSC::objectConstructorIsSealed):

• runtime/ReflectObject.cpp:

(JSC::reflectObjectPreventExtensions):

• runtime/Structure.cpp:

(JSC::Structure::Structure):
(JSC::Structure::preventExtensionsTransition):

• runtime/Structure.h:

File:

• trunk/Source/JavaScriptCore/runtime/JSModuleNamespaceObject.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/runtime/JSModuleNamespaceObject.cpp

@@ -50 +50 @@
 }
 
-void JSModuleNamespaceObject::finishCreation(VM& vm, JSGlobalObject* globalObject, JSModuleRecord* moduleRecord, const IdentifierSet& exports)
+void JSModuleNamespaceObject::finishCreation(ExecState* exec, JSGlobalObject* globalObject, JSModuleRecord* moduleRecord, const IdentifierSet& exports)
 {
+    VM& vm = exec->vm();
     Base::finishCreation(vm);
     ASSERT(inherits(info()));
@@ -79 +80 @@
     // http://www.ecma-international.org/ecma-262/6.0/#sec-module-namespace-exotic-objects-isextensible
     // http://www.ecma-international.org/ecma-262/6.0/#sec-module-namespace-exotic-objects-preventextensions
-    preventExtensions(vm);
+    methodTable(vm)->preventExtensions(this, exec);
+    ASSERT(!exec->hadException());
 }