Changeset 197533 in webkit for trunk/Source/JavaScriptCore/runtime/ProxyObject.h

Timestamp:

Mar 3, 2016, 5:07:04 PM (9 years ago)

Author:

[email protected]

Message:

[ES6] Implement Proxy.DefineOwnProperty
​https://bugs.webkit.org/show_bug.cgi?id=154759

Reviewed by Geoffrey Garen and Mark Lam.

This patch is a straight forward implementation of Proxy.DefineOwnProperty
with respect to section 9.5.6 of the ECMAScript spec.
​https://tc39.github.io/ecma262/#sec-proxy-object-internal-methods-and-internal-slots-defineownproperty-p-desc

• runtime/ObjectConstructor.cpp:

(JSC::objectConstructorGetOwnPropertyDescriptor):
(JSC::objectConstructorGetOwnPropertyDescriptors):

• runtime/ObjectConstructor.h:

(JSC::constructEmptyObject):
(JSC::constructObjectFromPropertyDescriptor):

• runtime/ProxyObject.cpp:

(JSC::ProxyObject::isExtensible):
(JSC::ProxyObject::performDefineOwnProperty):
(JSC::ProxyObject::defineOwnProperty):
(JSC::ProxyObject::visitChildren):

• runtime/ProxyObject.h:
• tests/es6.yaml:
• tests/stress/proxy-define-own-property.js: Added.

(assert):
(throw.new.Error):
(assert.let.handler.get defineProperty):
(assert.let.handler.defineProperty):
(let.handler.defineProperty):
(i.catch):
(assert.try.):
(assert.set get catch):
(assert.let.setter):
(assert.let.getter):
(assert.set get let.handler.defineProperty):
(assert.set get let):
(assert.):

File:

• trunk/Source/JavaScriptCore/runtime/ProxyObject.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/runtime/ProxyObject.h

@@ -72 +72 @@
     static bool preventExtensions(JSObject*, ExecState*);
     static bool isExtensible(JSObject*, ExecState*);
+    static bool defineOwnProperty(JSObject*, ExecState*, PropertyName, const PropertyDescriptor&, bool shouldThrow);
     static void visitChildren(JSCell*, SlotVisitor&);
 
@@ -83 +84 @@
     bool performPreventExtensions(ExecState*);
     bool performIsExtensible(ExecState*);
+    bool performDefineOwnProperty(ExecState*, PropertyName, const PropertyDescriptor&, bool shouldThrow);
 
     WriteBarrier<JSObject> m_target;