Changeset 197928 in webkit for trunk/Source/JavaScriptCore/parser/ParserModes.h

Timestamp:

Mar 10, 2016, 12:19:42 AM (9 years ago)

Author:

[email protected]

Message:

How we load new.target in arrow functions is broken
​https://bugs.webkit.org/show_bug.cgi?id=155153

Reviewed by Saam Barati.

Fixed not correct approach of caching new.target. In current patch was added code feature
flag that shows that current function is using new.target, when generating byte code an arrow
function we are loading new.target value to its register from arrow function lexical environment.

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitLoadNewTargetFromArrowFunctionLexicalEnvironment):

• bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::newTarget):

• parser/ASTBuilder.h:

(JSC::ASTBuilder::createNewTargetExpr):
(JSC::ASTBuilder::usesNewTarget):

• parser/Nodes.h:

(JSC::ScopeNode::usesNewTarget):

• parser/ParserModes.h:
• tests/stress/arrowfunction-lexical-bind-newtarget.js:

File:

• trunk/Source/JavaScriptCore/parser/ParserModes.h (modified) (1 diff)

trunk/Source/JavaScriptCore/parser/ParserModes.h

@@ -161 +161 @@
 const CodeFeatures SuperCallFeature =            1 << 10;
 const CodeFeatures SuperPropertyFeature =        1 << 11;
+const CodeFeatures NewTargetFeature =            1 << 12;
 
 const CodeFeatures AllFeatures = EvalFeature | ArgumentsFeature | WithFeature | ThisFeature | StrictModeFeature | ShadowsArgumentsFeature | ModifiedParameterFeature | ArrowFunctionFeature | ArrowFunctionContextFeature |
-    SuperCallFeature | SuperPropertyFeature;
+    SuperCallFeature | SuperPropertyFeature | NewTargetFeature;
 
 typedef uint8_t InnerArrowFunctionCodeFeatures;