Changeset 199276 in webkit for trunk/Source/JavaScriptCore/bindings/ScriptValue.cpp

Timestamp:

Apr 9, 2016, 1:54:57 PM (9 years ago)

Author:

[email protected]

Message:

Unreviewed, rolling out r199242.
​https://bugs.webkit.org/show_bug.cgi?id=156442

Caused many many leaks (Requested by ap on #webkit).

Reverted changeset:

"Web Inspector: get rid of InspectorBasicValue and
InspectorString subclasses"
​https://bugs.webkit.org/show_bug.cgi?id=156407
​http://trac.webkit.org/changeset/199242

File:

• trunk/Source/JavaScriptCore/bindings/ScriptValue.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/bindings/ScriptValue.cpp

@@ -113 +113 @@
         return InspectorValue::null();
     if (value.isBoolean())
-        return InspectorValue::create(value.asBoolean());
+        return InspectorBasicValue::create(value.asBoolean());
     if (value.isNumber() && value.isDouble())
-        return InspectorValue::create(value.asNumber());
+        return InspectorBasicValue::create(value.asNumber());
     if (value.isNumber() && value.isMachineInt())
-        return InspectorValue::create(static_cast<int>(value.asMachineInt()));
+        return InspectorBasicValue::create(static_cast<int>(value.asMachineInt()));
     if (value.isString())
-        return InspectorValue::create(value.getString(scriptState));
+        return InspectorString::create(value.getString(scriptState));
 
     if (value.isObject()) {