Changeset 199710 in webkit for trunk/Source/JavaScriptCore/assembler/LinkBuffer.h

Timestamp:

Apr 18, 2016, 11:54:25 PM (9 years ago)

Author:

[email protected]

Message:

[JSC] Fix some overhead affecting small codegen
​https://bugs.webkit.org/show_bug.cgi?id=156728

Patch by Benjamin Poulain <​[email protected]> on 2016-04-18
Reviewed by Filip Pizlo.

• assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::AbstractMacroAssembler):
(JSC::AbstractMacroAssembler::random):
cryptographicallyRandomNumber() is very costly.
We only need it in lowering some very particular cases
of non-trusted immediates. No inline cache needs that.

• assembler/LinkBuffer.h:

(JSC::LinkBuffer::link):

• jit/JIT.h:
• jit/JITInlines.h:

(JSC::JIT::addSlowCase):
Do not copy the JumpList to access its elements.

File:

• trunk/Source/JavaScriptCore/assembler/LinkBuffer.h (modified) (1 diff)

trunk/Source/JavaScriptCore/assembler/LinkBuffer.h

@@ -145 +145 @@
     }
 
-    void link(JumpList list, CodeLocationLabel label)
-    {
-        for (unsigned i = 0; i < list.m_jumps.size(); ++i)
-            link(list.m_jumps[i], label);
+    void link(const JumpList& list, CodeLocationLabel label)
+    {
+        for (const Jump& jump : list.jumps())
+            link(jump, label);
     }