Changeset 199863 in webkit for trunk/Source/JavaScriptCore/runtime/Executable.h

Timestamp:

Apr 21, 2016, 7:28:00 PM (9 years ago)

Author:

[email protected]

Message:

FTL should handle exceptions in operationInOptimize
​https://bugs.webkit.org/show_bug.cgi?id=156885

Reviewed by Michael Saboff.

For some reasone we didn't handle any exceptions in "in" when we called
operationInOptimize in the FTL.

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpAssumingJITType):

• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileIn):

• ftl/FTLPatchpointExceptionHandle.h: Add comments explaining which

function to use for different exception types.

• jsc.cpp:

(GlobalObject::finishCreation):
(functionNoFTL):

• runtime/Executable.cpp:

(JSC::ScriptExecutable::ScriptExecutable):

• runtime/Executable.h:

(JSC::ScriptExecutable::setNeverFTLOptimize):
(JSC::ScriptExecutable::neverFTLOptimize):

• tests/stress/in-ftl-exception-check.js: Added.

(foo):
(bar):
(catch):

File:

• trunk/Source/JavaScriptCore/runtime/Executable.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/runtime/Executable.h

@@ -358 +358 @@
     void setNeverInline(bool value) { m_neverInline = value; }
     void setNeverOptimize(bool value) { m_neverOptimize = value; }
+    void setNeverFTLOptimize(bool value) { m_neverFTLOptimize = value; }
     void setDidTryToEnterInLoop(bool value) { m_didTryToEnterInLoop = value; }
     bool neverInline() const { return m_neverInline; }
     bool neverOptimize() const { return m_neverOptimize; }
+    bool neverFTLOptimize() const { return m_neverFTLOptimize; }
     bool didTryToEnterInLoop() const { return m_didTryToEnterInLoop; }
     bool isInliningCandidate() const { return !neverInline(); }
@@ -420 +422 @@
     bool m_neverInline : 1;
     bool m_neverOptimize : 1;
+    bool m_neverFTLOptimize : 1;
     bool m_isArrowFunctionContext : 1;
     unsigned m_derivedContextType : 2; // DerivedContextType