Changeset 19994 in webkit for trunk/JavaScriptCore/kjs/collector.cpp

Timestamp:

Mar 6, 2007, 6:27:35 PM (18 years ago)

Author:

ggaren

Message:

Reviewed by Maciej Stachowiak.

2% speedup on super accurate JS iBench.

(KJS::Collector::collect): Removed anti-optimization to call
pthread_is_threaded_np() before calling pthread_main_np(). Almost all
apps have more than one thread, so the extra call is actually worse.
Interestingly, even the single-threaded testkjs shows a speed gain
from removing the pthread_is_threaded_np() short-circuit. Not sure why.

File:

• trunk/JavaScriptCore/kjs/collector.cpp (modified) (1 diff)

trunk/JavaScriptCore/kjs/collector.cpp

@@ -494 +494 @@
   
 #if USE(MULTIPLE_THREADS)
-    bool currentThreadIsMainThread = !pthread_is_threaded_np() || pthread_main_np();
+    bool currentThreadIsMainThread = pthread_main_np();
 #else
     bool currentThreadIsMainThread = true;